github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-10-11 21:07:03 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

greybus: arche-apb: Drop unnecessary checks

Browse Source 
wake_detect_gpio and resetn_gpio are guaranteed to be valid in
apb_ctrl_cleanup() and irq-handler, no need to check for their validity.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
This commit is contained in:
Viresh Kumar 2016-01-11 11:29:16 +05:30 committed by Greg Kroah-Hartman
parent d258432fb2
commit 40989cf3c1
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/staging/greybus/arche-apb-ctrl.c
View File

@ -94,10 +94,6 @@ static irqreturn_t apb_ctrl_wake_detect_irq(int irq, void *devid)
* signals, especially when we start using GPIOs over slow
* buses like I2C.
*/
if (!gpio_is_valid(apb->wake_detect_gpio) &&
!gpio_is_valid(apb->resetn_gpio))
return IRQ_HANDLED; /* Should it be IRQ_NONE ?? */
spin_lock_irqsave(&apb->lock, flags);
if (apb->state != APB_STATE_ACTIVE) {
@ -293,9 +289,7 @@ static void apb_ctrl_cleanup(struct arche_apb_ctrl_drvdata *apb)
spin_lock_irqsave(&apb->lock, flags);
/* As part of exit, put APB back in reset state */
if (gpio_is_valid(apb->resetn_gpio))
gpio_set_value(apb->resetn_gpio, 0);
gpio_set_value(apb->resetn_gpio, 0);
apb->state = APB_STATE_OFF;
spin_unlock_irqrestore(&apb->lock, flags);