github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-09 07:03:37 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

tcp: Fix a data-race around sysctl_tcp_nometrics_save.

Browse Source 
commit 8499a2454d upstream.

While reading sysctl_tcp_nometrics_save, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its reader.

Fixes: 1da177e4c3 ("Linux-2.6.12-rc2")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Kuniyuki Iwashima 2022-07-20 09:50:16 -07:00 committed by Greg Kroah-Hartman
parent 81c45f49e6
commit 3fb21b67c0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
net/ipv4/tcp_metrics.c
View File

@ -329,7 +329,7 @@ void tcp_update_metrics(struct sock *sk)
int m; int m;
sk_dst_confirm(sk); sk_dst_confirm(sk);
if (net->ipv4.sysctl_tcp_nometrics_save || !dst) if (READ_ONCE(net->ipv4.sysctl_tcp_nometrics_save) || !dst)
return; return;
rcu_read_lock(); rcu_read_lock();