github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-31 10:33:41 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

mm/damon/tests/core-kunit: handle alloc failure on damos_test_commit_filter()

Browse Source 
damon_test_commit_filter() is assuming all dynamic memory allocation in it
will succeed.  Those are indeed likely in the real use cases since those
allocations are too small to fail, but theoretically those could fail.  In
the case, inappropriate memory access can happen.  Fix it by appropriately
cleanup pre-allocated memory and skip the execution of the remaining tests
in the failure cases.

Link: https://lkml.kernel.org/r/20251101182021.74868-15-sj@kernel.org
Fixes: f6a4a150f1 ("mm/damon/tests/core-kunit: add damos_commit_filter test")
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Brendan Higgins <brendan.higgins@linux.dev>
Cc: David Gow <davidgow@google.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: <stable@vger.kernel.org>	[6.18+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
SeongJae Park 2025-11-01 11:20:08 -07:00 committed by Andrew Morton
parent 28ab2265e9
commit 3e5c4a1a17
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
mm/damon/tests/core-kunit.h
View File

@ -516,11 +516,16 @@ static void damos_test_new_filter(struct kunit *test)
static void damos_test_commit_filter(struct kunit *test)
{
struct damos_filter *src_filter = damos_new_filter(
DAMOS_FILTER_TYPE_ANON, true, true);
struct damos_filter *dst_filter = damos_new_filter(
DAMOS_FILTER_TYPE_ACTIVE, false, false);
struct damos_filter *src_filter, *dst_filter;
src_filter = damos_new_filter(DAMOS_FILTER_TYPE_ANON, true, true);
if (!src_filter)
kunit_skip(test, "src filter alloc fail");
dst_filter = damos_new_filter(DAMOS_FILTER_TYPE_ACTIVE, false, false);
if (!dst_filter) {
damos_destroy_filter(src_filter);
kunit_skip(test, "dst filter alloc fail");
}
damos_commit_filter(dst_filter, src_filter);
KUNIT_EXPECT_EQ(test, dst_filter->type, src_filter->type);
KUNIT_EXPECT_EQ(test, dst_filter->matching, src_filter->matching);