github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-11-07 06:17:02 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

misc: Kconfig: tc9564: fix and simplify dependencies

Browse Source 
The TC9564_PCI config option selects PCI_DYNAMIC_OF_NODES.  But that
depends on OF_IRQ, and TC9564_PCI does not satisfy that dependency.
Simply adding "depends on OF_IRQ" results in a recursive Kconfig
dependency.

A little experimentation shows that *depending on* rather than
*selecting* PCI_QUIRKS allows us to avoid the recursion when
depending on OF_IRQ.

Separately, PCI_DYNAMIC_OF_NODES is a user-visible option, so it
should be depended on, not selected.  Changing this allows some
further simplification.

PCI_DYNAMIC_OF_NODES is only exposed as an option if PCI is enabled,
so by depending on it, we can omit the dependency on PCI.

Additionally, PCI_DYNAMIC_OF_NODES depends on OF_IRQ, so we can omit
the explicit OF_IRQ dependency.

Finally, OF_IRQ is only exposed as an option if OF is enabled, so we
can skip explicitly depending on OF as well.

In summary, depending on (rather than selecting) PCI_DYNAMIC_OF_NODES
satisfies the dependencies on PCI, OF_IRQ, and OF.  We still need to
*depend on* PCI_QUIRKS, to avoid the circular dependency related to
OF_IRQ.

Simplify the dependencies for TC9564_PCI to just depending on
PCI_DYNAMIC_OF_NODES and PCI_QUIRKS.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202610020124.ieOiopjQ-lkp@intel.com/
Closes: https://lore.kernel.org/oe-kbuild-all/202610021154.ObogJhHN-lkp@intel.com/
Closes: https://lore.kernel.org/oe-kbuild-all/202610021249.J94Hg1xo-lkp@intel.com/
Suggested-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 1304b0c47e ("misc: tc9564: introduce base PCI driver")
Signed-off-by: Alex Elder <elder@riscstar.com>
Link: https://patch.msgid.link/20261002155709.492894-1-elder@riscstar.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Alex Elder 2026-10-02 10:57:08 -05:00 committed by Greg Kroah-Hartman
parent 099460e42a
commit 3d1986a982
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/misc/Kconfig
View File

@ -570,10 +570,8 @@ config MCHP_LAN966X_PCI
config TC9564_PCI
tristate "Toshiba TC9564 PCI function support"
depends on OF
depends on PCI
select PCI_DYNAMIC_OF_NODES
select PCI_QUIRKS
depends on PCI_DYNAMIC_OF_NODES
depends on PCI_QUIRKS
default m
help
This enables support for two PCI functions implemented by the