github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-09-23 05:04:02 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

f2fs: fix to do sanity check on nat entry of quota inode

Browse Source 
As Zhiguo reported, nat entry of quota inode could be corrupted:

"ino/block_addr=NULL_ADDR in nid=4 entry"

We'd better to do sanity check on quota inode to detect and record
nat.blk_addr inconsistency, so that we can have a chance to repair
it w/ later fsck.

Reported-by: Zhiguo Niu <zhiguo.niu@unisoc.com>
Signed-off-by: Chao Yu <chao@kernel.org>
Reviewed-by: Zhiguo Niu <zhiguo.niu@unisoc.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
This commit is contained in:
Chao Yu 2025-12-19 10:51:04 +08:00 committed by Jaegeuk Kim
parent 3250bd41d9
commit 3cb396a2c7
3 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
fs/f2fs/f2fs.h
View File

@ -4917,16 +4917,16 @@ static inline bool is_journalled_quota(struct f2fs_sb_info *sbi)
return false;
}
static inline bool f2fs_quota_file(struct inode *inode)
static inline bool f2fs_quota_file(struct f2fs_sb_info *sbi, nid_t ino)
{
#ifdef CONFIG_QUOTA
int i;
if (!f2fs_sb_has_quota_ino(F2FS_I_SB(inode)))
if (!f2fs_sb_has_quota_ino(sbi))
return false;
for (i = 0; i < MAXQUOTAS; i++) {
if (f2fs_qf_ino(F2FS_I_SB(inode)->sb, i) == inode->i_ino)
if (f2fs_qf_ino(sbi->sb, i) == ino)
return true;
}
#endif

2
fs/f2fs/inode.c
View File

@ -621,7 +621,7 @@ struct inode *f2fs_iget(struct super_block *sb, unsigned long ino)
inode->i_fop = &f2fs_file_operations;
inode->i_mapping->a_ops = &f2fs_dblock_aops;
if (IS_IMMUTABLE(inode) && !f2fs_compressed_file(inode) &&
!f2fs_quota_file(inode))
!f2fs_quota_file(sbi, inode->i_ino))
mapping_set_folio_min_order(inode->i_mapping, 0);
} else if (S_ISDIR(inode->i_mode)) {
inode->i_op = &f2fs_dir_inode_operations;

11
fs/f2fs/node.c
View File

@ -643,6 +643,17 @@ int f2fs_get_node_info(struct f2fs_sb_info *sbi, nid_t nid,
return -EFSCORRUPTED;
}
if (unlikely(f2fs_quota_file(sbi, ni->nid) &&
!__is_valid_data_blkaddr(ni->blk_addr))) {
set_sbi_flag(sbi, SBI_NEED_FSCK);
f2fs_err_ratelimited(sbi,
"f2fs_get_node_info of %pS: inconsistent nat entry from qf_ino, "
"ino:%u, nid:%u, blkaddr:%u, ver:%u, flag:%u",
__builtin_return_address(0),
ni->ino, ni->nid, ni->blk_addr, ni->version, ni->flag);
f2fs_handle_error(sbi, ERROR_INCONSISTENT_NAT);
}
/* cache nat entry */
if (need_cache)
cache_nat_entry(sbi, nid, &ne);