From 3bbbeb7fddf54a7d7116b2defe0a63a9b583c84e Mon Sep 17 00:00:00 2001 From: bui duc phuc Date: Mon, 10 Aug 2026 15:26:05 +0700 Subject: [PATCH] watchdog: orion_wdt: Propagate errors from optional IRQ lookup platform_get_irq_optional() returns a positive IRQ number on success or a negative error code on failure. For an optional IRQ, -ENXIO indicates that no IRQ is available, while other errors should be propagated. Propagate errors such as -EPROBE_DEFER and -EINVAL instead of continuing probe without the IRQ. Signed-off-by: bui duc phuc Link: https://lore.kernel.org/r/20260810082606.42623-1-phucduc.bui@gmail.com Signed-off-by: Guenter Roeck --- drivers/watchdog/orion_wdt.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/watchdog/orion_wdt.c b/drivers/watchdog/orion_wdt.c index 1802634cc7cd..0ea946823b0a 100644 --- a/drivers/watchdog/orion_wdt.c +++ b/drivers/watchdog/orion_wdt.c @@ -606,6 +606,10 @@ static int orion_wdt_probe(struct platform_device *pdev) /* Request the IRQ only after the watchdog is disabled */ irq = platform_get_irq_optional(pdev, 0); + if (irq < 0 && irq != -ENXIO) { + ret = irq; + goto disable_clk; + } if (irq > 0) { /* * Not all supported platforms specify an interrupt for the @@ -619,6 +623,10 @@ static int orion_wdt_probe(struct platform_device *pdev) /* Optional 2nd interrupt for pretimeout */ irq = platform_get_irq_optional(pdev, 1); + if (irq < 0 && irq != -ENXIO) { + ret = irq; + goto disable_clk; + } if (irq > 0) { orion_wdt_info.options |= WDIOF_PRETIMEOUT; ret = devm_request_irq(&pdev->dev, irq, orion_wdt_pre_irq,