mirror of
https://github.com/torvalds/linux.git
synced 2026-06-06 13:37:36 +02:00
net: pktgen: fix 'rate 0' error handling (return -EINVAL)
Given an invalid 'rate' command e.g. 'rate 0' the return value is '1', leading to the following misleading output: - the good case $ echo "rate 100" > /proc/net/pktgen/lo\@0 $ grep "Result:" /proc/net/pktgen/lo\@0 Result: OK: rate=100 - the bad case (before the patch) $ echo "rate 0" > /proc/net/pktgen/lo\@0" -bash: echo: write error: Invalid argument $ grep "Result:" /proc/net/pktgen/lo\@0 Result: No such parameter "ate" - with patch applied $ echo "rate 0" > /proc/net/pktgen/lo\@0 -bash: echo: write error: Invalid argument $ grep "Result:" /proc/net/pktgen/lo\@0 Result: Idle Signed-off-by: Peter Seiderer <ps.report@gmx.net> Reviewed-by: Simon Horman <horms@kernel.org> Link: https://patch.msgid.link/20250219084527.20488-5-ps.report@gmx.net Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
parent
b38504346a
commit
3ba38c25a8
|
|
@ -1115,7 +1115,7 @@ static ssize_t pktgen_if_write(struct file *file,
|
|||
|
||||
i += len;
|
||||
if (!value)
|
||||
return len;
|
||||
return -EINVAL;
|
||||
pkt_dev->delay = pkt_dev->min_pkt_size*8*NSEC_PER_USEC/value;
|
||||
if (debug)
|
||||
pr_info("Delay set at: %llu ns\n", pkt_dev->delay);
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user