rtc: ds1685: keep setting PAB until power is removed

A kickstart or wake-up flag set while its interrupt is enabled (KF with
KSE, WF with WIE) clears PAB, and the system stays powered. Clear the
event flags together with setting PAB, and repeat the write until power
is gone.

Signed-off-by: Imre Kaloz <kaloz@kernel.org>
Acked-by: Joshua Kinard <linux@kumba.dev>
Link: https://patch.msgid.link/20261013120208.11268-4-kaloz@kernel.org
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
This commit is contained in:
Imre Kaloz 2026-10-13 14:02:08 +02:00 committed by Alexandre Belloni
parent 21a829af60
commit 3b6cdc3655

View File

@ -1423,15 +1423,21 @@ ds1685_rtc_poweroff(struct platform_device *pdev)
rtc->write(rtc, RTC_EXT_CTRL_4B, ctrl4b);
}
/* Set PAB to 1 in Control 4A to power the system down. */
/*
* Set PAB to 1 in Control 4A to power the system down. PAB
* is cleared again while KF and KSE, or WF and WIE, are set,
* so keep clearing the flags and setting PAB until power is
* gone. We do not switch back to bank0.
*/
dev_warn(&pdev->dev, "Powerdown.\n");
mdelay(20);
rtc->write(rtc, RTC_EXT_CTRL_4A,
(ctrl4a | RTC_CTRL_4A_PAB));
/* Spin ... we do not switch back to bank0. */
while(1);
unreachable();
while (1) {
ctrl4a = rtc->read(rtc, RTC_EXT_CTRL_4A);
rtc->write(rtc, RTC_EXT_CTRL_4A,
(ctrl4a & ~RTC_CTRL_4A_RWK_MASK) |
RTC_CTRL_4A_PAB);
mdelay(100);
}
}
}
EXPORT_SYMBOL_GPL(ds1685_rtc_poweroff);