github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-09-24 06:24:02 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

drm/amdgpu/pm/powerplay: bounds-check voltage index in SMU7 lookup

Browse Source 
vddInd and vddcInd fields from VBIOS-parsed tables are used to index into
voltage lookup tables without a bounds check. Return -EINVAL when any
index is out of range.

Fixes: c82baa2818 ("drm/amd/powerplay: add Tonga dpm support (v3)")
Signed-off-by: Asad Kamal <asad.kamal@amd.com>
Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
This commit is contained in:
Asad Kamal 2026-06-23 00:00:00 +00:00 committed by Alex Deucher
parent 53ef33c084
commit 3a8a05477c
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c
View File

@ -2216,12 +2216,24 @@ static int smu7_patch_voltage_dependency_tables_with_lookup_table(
if (data->vdd_gfx_control == SMU7_VOLTAGE_CONTROL_BY_SVID2) {
for (entry_id = 0; entry_id < sclk_table->count; ++entry_id) {
voltage_id = sclk_table->entries[entry_id].vddInd;
if (voltage_id >= table_info->vddgfx_lookup_table->count) {
pr_err("amdgpu: sclk[%u] vddgfx index %u out of bounds (%u)\n",
entry_id, voltage_id,
table_info->vddgfx_lookup_table->count);
return -EINVAL;
}
sclk_table->entries[entry_id].vddgfx =
table_info->vddgfx_lookup_table->entries[voltage_id].us_vdd;
}
} else {
for (entry_id = 0; entry_id < sclk_table->count; ++entry_id) {
voltage_id = sclk_table->entries[entry_id].vddInd;
if (voltage_id >= table_info->vddc_lookup_table->count) {
pr_err("amdgpu: sclk[%u] vddc index %u out of bounds (%u)\n",
entry_id, voltage_id,
table_info->vddc_lookup_table->count);
return -EINVAL;
}
sclk_table->entries[entry_id].vddc =
table_info->vddc_lookup_table->entries[voltage_id].us_vdd;
}
@ -2229,12 +2241,24 @@ static int smu7_patch_voltage_dependency_tables_with_lookup_table(
for (entry_id = 0; entry_id < mclk_table->count; ++entry_id) {
voltage_id = mclk_table->entries[entry_id].vddInd;
if (voltage_id >= table_info->vddc_lookup_table->count) {
pr_err("amdgpu: mclk[%u] vddc index %u out of bounds (%u)\n",
entry_id, voltage_id,
table_info->vddc_lookup_table->count);
return -EINVAL;
}
mclk_table->entries[entry_id].vddc =
table_info->vddc_lookup_table->entries[voltage_id].us_vdd;
}
for (entry_id = 0; entry_id < mm_table->count; ++entry_id) {
voltage_id = mm_table->entries[entry_id].vddcInd;
if (voltage_id >= table_info->vddc_lookup_table->count) {
pr_err("amdgpu: mm[%u] vddc index %u out of bounds (%u)\n",
entry_id, voltage_id,
table_info->vddc_lookup_table->count);
return -EINVAL;
}
mm_table->entries[entry_id].vddc =
table_info->vddc_lookup_table->entries[voltage_id].us_vdd;
}