github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-07-30 19:21:28 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

media: imx: imx8mq-mipi_csi2: Remove unneeded code

Browse Source 
ret is constant in imx8mq_mipi_csi_pm_suspend(). This function cannot
return error. Remove the return variable. Simplify other functions which
are using this function.

Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
This commit is contained in:
Muhammad Usama Anjum 2022-01-28 18:07:22 +01:00 committed by Mauro Carvalho Chehab
parent f99c4ad386
commit 3a6cddab2d
1 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
drivers/staging/media/imx/imx8mq-mipi-csi2.c
View File

@ -693,11 +693,10 @@ static int imx8mq_mipi_csi_async_register(struct csi_state *state)
* Suspend/resume
*/
static int imx8mq_mipi_csi_pm_suspend(struct device *dev)
static void imx8mq_mipi_csi_pm_suspend(struct device *dev)
{
struct v4l2_subdev *sd = dev_get_drvdata(dev);
struct csi_state *state = mipi_sd_to_csi2_state(sd);
int ret = 0;
mutex_lock(&state->lock);
@ -708,8 +707,6 @@ static int imx8mq_mipi_csi_pm_suspend(struct device *dev)
}
mutex_unlock(&state->lock);
return ret ? -EAGAIN : 0;
}
static int imx8mq_mipi_csi_pm_resume(struct device *dev)
@ -742,15 +739,12 @@ static int __maybe_unused imx8mq_mipi_csi_suspend(struct device *dev)
{
struct v4l2_subdev *sd = dev_get_drvdata(dev);
struct csi_state *state = mipi_sd_to_csi2_state(sd);
int ret;
ret = imx8mq_mipi_csi_pm_suspend(dev);
if (ret)
return ret;
imx8mq_mipi_csi_pm_suspend(dev);
state->state |= ST_SUSPENDED;
return ret;
return 0;
}
static int __maybe_unused imx8mq_mipi_csi_resume(struct device *dev)
@ -770,9 +764,7 @@ static int __maybe_unused imx8mq_mipi_csi_runtime_suspend(struct device *dev)
struct csi_state *state = mipi_sd_to_csi2_state(sd);
int ret;
ret = imx8mq_mipi_csi_pm_suspend(dev);
if (ret)
return ret;
imx8mq_mipi_csi_pm_suspend(dev);
ret = icc_set_bw(state->icc_path, 0, 0);
if (ret)