github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-07-31 03:27:03 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

iio: qcom-spmi-adc5-gen3 : add support to clear conversion fault

Browse Source 
When an ADC conversion results in a conversion fault, the
conversion fault bit in the status register is set, but never
cleared, by PBS, causing an error print for conversion fault
to appear for all future conversions. Update interrupt handler
to clear conversion fault bit if it is found set.

Change-Id: I83b36ce585ab5d20639dbf5050f91e8850cc2b75
Signed-off-by: Jishnu Prakash <jprakash@codeaurora.org>
This commit is contained in:
Jishnu Prakash 2021-08-23 22:50:02 +05:30 committed by David Collins
parent 7722611a92
commit 3a2a5ea5ee
1 changed files with 24 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
drivers/iio/adc/qcom-spmi-adc5-gen3.c
View File

@ -50,6 +50,9 @@ static LIST_HEAD(adc_tm_device_list);
#define ADC5_GEN3_TM_LOW_STS_CLR 0x4d
#define ADC5_GEN3_CONV_ERR_CLR 0x4e
#define ADC5_GEN3_CONV_ERR_CLR_REQ BIT(0)
#define ADC5_GEN3_SID 0x4f
#define ADC5_GEN3_SID_MASK 0xf
@ -532,7 +535,7 @@ static void adc5_gen3_dump_regs_debug(struct adc5_chip *adc)
static irqreturn_t adc5_gen3_isr(int irq, void *dev_id)
{
struct adc5_chip *adc = dev_id;
u8 status, tm_status[2], eoc_status;
u8 status, tm_status[2], eoc_status, val;
int ret;
ret = adc5_read(adc, ADC5_GEN3_EOC_STS, &eoc_status, 1);
@ -566,6 +569,22 @@ static irqreturn_t adc5_gen3_isr(int irq, void *dev_id)
if (status & ADC5_GEN3_STATUS1_CONV_FAULT) {
pr_err("Unexpected conversion fault\n");
adc5_gen3_dump_regs_debug(adc);
val = ADC5_GEN3_CONV_ERR_CLR_REQ;
ret = adc5_write(adc, ADC5_GEN3_CONV_ERR_CLR, &val, 1);
if (ret < 0)
goto handler_end;
/* To indicate conversion request is only to clear a status */
val = 0;
ret = adc5_write(adc, ADC5_GEN3_PERPH_CH, &val, 1);
if (ret < 0)
goto handler_end;
val = ADC5_GEN3_CONV_REQ_REQ;
ret = adc5_write(adc, ADC5_GEN3_CONV_REQ, &val, 1);
if (ret < 0)
goto handler_end;
}
handler_end:
@ -597,6 +616,10 @@ static void tm_handler_work(struct work_struct *work)
/* To indicate conversion request is only to clear a status */
val = 0;
ret = adc5_write(adc, ADC5_GEN3_PERPH_CH, &val, 1);
if (ret < 0) {
pr_err("adc write status clear conv_req failed with %d\n", ret);
goto work_unlock;
}
val = ADC5_GEN3_CONV_REQ_REQ;
ret = adc5_write(adc, ADC5_GEN3_CONV_REQ, &val, 1);