mirror of
https://github.com/torvalds/linux.git
synced 2026-07-31 11:37:06 +02:00
net: stmmac: rk: combine .set_*_speed() methods
As a result of the previous patches, many of the .set_rgmii_speed() and .set_rmii_speed() implementations are identical apart from the interface mode. Add a new .set_speed() function which takes the interface mode in addition to the speed, and use it to combine the separate implementations, calling the common rk_set_reg_speed() function. Also convert rk_set_clk_mac_speed() to be called by this new method pointer, rather than having these implementations called from both .set_*_speed() methods. Remove all the error messages from the .set_speed() methods, as these return an error code which is propagated up to stmmac_mac_link_up() which will print the error. Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Link: https://patch.msgid.link/E1uPk39-004CFf-7a@rmk-PC.armlinux.org.uk Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
parent
d8d6096f81
commit
3930c2cca6
|
|
@ -39,6 +39,8 @@ struct rk_gmac_ops {
|
|||
void (*set_to_rmii)(struct rk_priv_data *bsp_priv);
|
||||
void (*set_rgmii_speed)(struct rk_priv_data *bsp_priv, int speed);
|
||||
void (*set_rmii_speed)(struct rk_priv_data *bsp_priv, int speed);
|
||||
int (*set_speed)(struct rk_priv_data *bsp_priv,
|
||||
phy_interface_t interface, int speed);
|
||||
void (*set_clock_selection)(struct rk_priv_data *bsp_priv, bool input,
|
||||
bool enable);
|
||||
void (*integrated_phy_powerup)(struct rk_priv_data *bsp_priv);
|
||||
|
|
@ -137,39 +139,17 @@ static int rk_set_reg_speed(struct rk_priv_data *bsp_priv,
|
|||
|
||||
}
|
||||
|
||||
static int rk_set_reg_speed_rgmii(struct rk_priv_data *bsp_priv,
|
||||
const struct rk_reg_speed_data *rsd,
|
||||
unsigned int reg, int speed)
|
||||
{
|
||||
return rk_set_reg_speed(bsp_priv, rsd, reg, PHY_INTERFACE_MODE_RGMII,
|
||||
speed);
|
||||
}
|
||||
|
||||
static int rk_set_reg_speed_rmii(struct rk_priv_data *bsp_priv,
|
||||
const struct rk_reg_speed_data *rsd,
|
||||
unsigned int reg, int speed)
|
||||
{
|
||||
return rk_set_reg_speed(bsp_priv, rsd, reg, PHY_INTERFACE_MODE_RMII,
|
||||
speed);
|
||||
}
|
||||
|
||||
static void rk_set_clk_mac_speed(struct rk_priv_data *bsp_priv, int speed)
|
||||
static int rk_set_clk_mac_speed(struct rk_priv_data *bsp_priv,
|
||||
phy_interface_t interface, int speed)
|
||||
{
|
||||
struct clk *clk_mac_speed = bsp_priv->clks[RK_CLK_MAC_SPEED].clk;
|
||||
struct device *dev = &bsp_priv->pdev->dev;
|
||||
long rate;
|
||||
int ret;
|
||||
|
||||
rate = rgmii_clock(speed);
|
||||
if (rate < 0) {
|
||||
dev_err(dev, "unknown speed value for GMAC speed=%d", speed);
|
||||
return;
|
||||
}
|
||||
if (rate < 0)
|
||||
return rate;
|
||||
|
||||
ret = clk_set_rate(clk_mac_speed, rate);
|
||||
if (ret)
|
||||
dev_err(dev, "%s: set clk_mac_speed rate %ld failed %d\n",
|
||||
__func__, rate, ret);
|
||||
return clk_set_rate(clk_mac_speed, rate);
|
||||
}
|
||||
|
||||
#define HIWORD_UPDATE(val, mask, shift) \
|
||||
|
|
@ -358,29 +338,17 @@ static const struct rk_reg_speed_data rk3128_reg_speed_data = {
|
|||
.rmii_100 = RK3128_GMAC_RMII_CLK_25M | RK3128_GMAC_SPEED_100M,
|
||||
};
|
||||
|
||||
static void rk3128_set_rgmii_speed(struct rk_priv_data *bsp_priv, int speed)
|
||||
static int rk3128_set_speed(struct rk_priv_data *bsp_priv,
|
||||
phy_interface_t interface, int speed)
|
||||
{
|
||||
struct device *dev = &bsp_priv->pdev->dev;
|
||||
|
||||
if (rk_set_reg_speed_rgmii(bsp_priv, &rk3128_reg_speed_data,
|
||||
RK3128_GRF_MAC_CON1, speed))
|
||||
dev_err(dev, "unknown speed value for RGMII! speed=%d", speed);
|
||||
}
|
||||
|
||||
static void rk3128_set_rmii_speed(struct rk_priv_data *bsp_priv, int speed)
|
||||
{
|
||||
struct device *dev = &bsp_priv->pdev->dev;
|
||||
|
||||
if (rk_set_reg_speed_rmii(bsp_priv, &rk3128_reg_speed_data,
|
||||
RK3128_GRF_MAC_CON1, speed))
|
||||
dev_err(dev, "unknown speed value for RMII! speed=%d", speed);
|
||||
return rk_set_reg_speed(bsp_priv, &rk3128_reg_speed_data,
|
||||
RK3128_GRF_MAC_CON1, interface, speed);
|
||||
}
|
||||
|
||||
static const struct rk_gmac_ops rk3128_ops = {
|
||||
.set_to_rgmii = rk3128_set_to_rgmii,
|
||||
.set_to_rmii = rk3128_set_to_rmii,
|
||||
.set_rgmii_speed = rk3128_set_rgmii_speed,
|
||||
.set_rmii_speed = rk3128_set_rmii_speed,
|
||||
.set_speed = rk3128_set_speed,
|
||||
};
|
||||
|
||||
#define RK3228_GRF_MAC_CON0 0x0900
|
||||
|
|
@ -447,22 +415,11 @@ static const struct rk_reg_speed_data rk3228_reg_speed_data = {
|
|||
.rmii_100 = RK3228_GMAC_RMII_CLK_25M | RK3228_GMAC_SPEED_100M,
|
||||
};
|
||||
|
||||
static void rk3228_set_rgmii_speed(struct rk_priv_data *bsp_priv, int speed)
|
||||
static int rk3228_set_speed(struct rk_priv_data *bsp_priv,
|
||||
phy_interface_t interface, int speed)
|
||||
{
|
||||
struct device *dev = &bsp_priv->pdev->dev;
|
||||
|
||||
if (rk_set_reg_speed_rgmii(bsp_priv, &rk3228_reg_speed_data,
|
||||
RK3228_GRF_MAC_CON1, speed))
|
||||
dev_err(dev, "unknown speed value for RGMII! speed=%d", speed);
|
||||
}
|
||||
|
||||
static void rk3228_set_rmii_speed(struct rk_priv_data *bsp_priv, int speed)
|
||||
{
|
||||
struct device *dev = &bsp_priv->pdev->dev;
|
||||
|
||||
if (rk_set_reg_speed_rmii(bsp_priv, &rk3228_reg_speed_data,
|
||||
RK3228_GRF_MAC_CON1, speed))
|
||||
dev_err(dev, "unknown speed value for RMII! speed=%d", speed);
|
||||
return rk_set_reg_speed(bsp_priv, &rk3228_reg_speed_data,
|
||||
RK3228_GRF_MAC_CON1, interface, speed);
|
||||
}
|
||||
|
||||
static void rk3228_integrated_phy_powerup(struct rk_priv_data *priv)
|
||||
|
|
@ -476,8 +433,7 @@ static void rk3228_integrated_phy_powerup(struct rk_priv_data *priv)
|
|||
static const struct rk_gmac_ops rk3228_ops = {
|
||||
.set_to_rgmii = rk3228_set_to_rgmii,
|
||||
.set_to_rmii = rk3228_set_to_rmii,
|
||||
.set_rgmii_speed = rk3228_set_rgmii_speed,
|
||||
.set_rmii_speed = rk3228_set_rmii_speed,
|
||||
.set_speed = rk3228_set_speed,
|
||||
.integrated_phy_powerup = rk3228_integrated_phy_powerup,
|
||||
.integrated_phy_powerdown = rk_gmac_integrated_ephy_powerdown,
|
||||
};
|
||||
|
|
@ -536,29 +492,17 @@ static const struct rk_reg_speed_data rk3288_reg_speed_data = {
|
|||
.rmii_100 = RK3288_GMAC_RMII_CLK_25M | RK3288_GMAC_SPEED_100M,
|
||||
};
|
||||
|
||||
static void rk3288_set_rgmii_speed(struct rk_priv_data *bsp_priv, int speed)
|
||||
static int rk3288_set_speed(struct rk_priv_data *bsp_priv,
|
||||
phy_interface_t interface, int speed)
|
||||
{
|
||||
struct device *dev = &bsp_priv->pdev->dev;
|
||||
|
||||
if (rk_set_reg_speed_rgmii(bsp_priv, &rk3288_reg_speed_data,
|
||||
RK3288_GRF_SOC_CON1, speed))
|
||||
dev_err(dev, "unknown speed value for RGMII! speed=%d", speed);
|
||||
}
|
||||
|
||||
static void rk3288_set_rmii_speed(struct rk_priv_data *bsp_priv, int speed)
|
||||
{
|
||||
struct device *dev = &bsp_priv->pdev->dev;
|
||||
|
||||
if (rk_set_reg_speed_rmii(bsp_priv, &rk3288_reg_speed_data,
|
||||
RK3288_GRF_SOC_CON1, speed))
|
||||
dev_err(dev, "unknown speed value for RMII! speed=%d", speed);
|
||||
return rk_set_reg_speed(bsp_priv, &rk3288_reg_speed_data,
|
||||
RK3288_GRF_SOC_CON1, interface, speed);
|
||||
}
|
||||
|
||||
static const struct rk_gmac_ops rk3288_ops = {
|
||||
.set_to_rgmii = rk3288_set_to_rgmii,
|
||||
.set_to_rmii = rk3288_set_to_rmii,
|
||||
.set_rgmii_speed = rk3288_set_rgmii_speed,
|
||||
.set_rmii_speed = rk3288_set_rmii_speed,
|
||||
.set_speed = rk3288_set_speed,
|
||||
};
|
||||
|
||||
#define RK3308_GRF_MAC_CON0 0x04a0
|
||||
|
|
@ -582,18 +526,16 @@ static const struct rk_reg_speed_data rk3308_reg_speed_data = {
|
|||
.rmii_100 = RK3308_GMAC_SPEED_100M,
|
||||
};
|
||||
|
||||
static void rk3308_set_rmii_speed(struct rk_priv_data *bsp_priv, int speed)
|
||||
static int rk3308_set_speed(struct rk_priv_data *bsp_priv,
|
||||
phy_interface_t interface, int speed)
|
||||
{
|
||||
struct device *dev = &bsp_priv->pdev->dev;
|
||||
|
||||
if (rk_set_reg_speed_rmii(bsp_priv, &rk3308_reg_speed_data,
|
||||
RK3308_GRF_MAC_CON0, speed))
|
||||
dev_err(dev, "unknown speed value for RMII! speed=%d", speed);
|
||||
return rk_set_reg_speed(bsp_priv, &rk3308_reg_speed_data,
|
||||
RK3308_GRF_MAC_CON0, interface, speed);
|
||||
}
|
||||
|
||||
static const struct rk_gmac_ops rk3308_ops = {
|
||||
.set_to_rmii = rk3308_set_to_rmii,
|
||||
.set_rmii_speed = rk3308_set_rmii_speed,
|
||||
.set_speed = rk3308_set_speed,
|
||||
};
|
||||
|
||||
#define RK3328_GRF_MAC_CON0 0x0900
|
||||
|
|
@ -663,25 +605,18 @@ static const struct rk_reg_speed_data rk3328_reg_speed_data = {
|
|||
.rmii_100 = RK3328_GMAC_RMII_CLK_25M | RK3328_GMAC_SPEED_100M,
|
||||
};
|
||||
|
||||
static void rk3328_set_rgmii_speed(struct rk_priv_data *bsp_priv, int speed)
|
||||
static int rk3328_set_speed(struct rk_priv_data *bsp_priv,
|
||||
phy_interface_t interface, int speed)
|
||||
{
|
||||
struct device *dev = &bsp_priv->pdev->dev;
|
||||
|
||||
if (rk_set_reg_speed_rgmii(bsp_priv, &rk3328_reg_speed_data,
|
||||
RK3328_GRF_MAC_CON1, speed))
|
||||
dev_err(dev, "unknown speed value for RGMII! speed=%d", speed);
|
||||
}
|
||||
|
||||
static void rk3328_set_rmii_speed(struct rk_priv_data *bsp_priv, int speed)
|
||||
{
|
||||
struct device *dev = &bsp_priv->pdev->dev;
|
||||
unsigned int reg;
|
||||
|
||||
reg = bsp_priv->integrated_phy ? RK3328_GRF_MAC_CON2 :
|
||||
RK3328_GRF_MAC_CON1;
|
||||
if (interface == PHY_INTERFACE_MODE_RMII && bsp_priv->integrated_phy)
|
||||
reg = RK3328_GRF_MAC_CON2;
|
||||
else
|
||||
reg = RK3328_GRF_MAC_CON1;
|
||||
|
||||
if (rk_set_reg_speed_rmii(bsp_priv, &rk3328_reg_speed_data, reg, speed))
|
||||
dev_err(dev, "unknown speed value for RMII! speed=%d", speed);
|
||||
return rk_set_reg_speed(bsp_priv, &rk3328_reg_speed_data, reg,
|
||||
interface, speed);
|
||||
}
|
||||
|
||||
static void rk3328_integrated_phy_powerup(struct rk_priv_data *priv)
|
||||
|
|
@ -695,8 +630,7 @@ static void rk3328_integrated_phy_powerup(struct rk_priv_data *priv)
|
|||
static const struct rk_gmac_ops rk3328_ops = {
|
||||
.set_to_rgmii = rk3328_set_to_rgmii,
|
||||
.set_to_rmii = rk3328_set_to_rmii,
|
||||
.set_rgmii_speed = rk3328_set_rgmii_speed,
|
||||
.set_rmii_speed = rk3328_set_rmii_speed,
|
||||
.set_speed = rk3328_set_speed,
|
||||
.integrated_phy_powerup = rk3328_integrated_phy_powerup,
|
||||
.integrated_phy_powerdown = rk_gmac_integrated_ephy_powerdown,
|
||||
};
|
||||
|
|
@ -755,29 +689,17 @@ static const struct rk_reg_speed_data rk3366_reg_speed_data = {
|
|||
.rmii_100 = RK3366_GMAC_RMII_CLK_25M | RK3366_GMAC_SPEED_100M,
|
||||
};
|
||||
|
||||
static void rk3366_set_rgmii_speed(struct rk_priv_data *bsp_priv, int speed)
|
||||
static int rk3366_set_speed(struct rk_priv_data *bsp_priv,
|
||||
phy_interface_t interface, int speed)
|
||||
{
|
||||
struct device *dev = &bsp_priv->pdev->dev;
|
||||
|
||||
if (rk_set_reg_speed_rgmii(bsp_priv, &rk3366_reg_speed_data,
|
||||
RK3366_GRF_SOC_CON6, speed))
|
||||
dev_err(dev, "unknown speed value for RGMII! speed=%d", speed);
|
||||
}
|
||||
|
||||
static void rk3366_set_rmii_speed(struct rk_priv_data *bsp_priv, int speed)
|
||||
{
|
||||
struct device *dev = &bsp_priv->pdev->dev;
|
||||
|
||||
if (rk_set_reg_speed_rmii(bsp_priv, &rk3366_reg_speed_data,
|
||||
RK3366_GRF_SOC_CON6, speed))
|
||||
dev_err(dev, "unknown speed value for RMII! speed=%d", speed);
|
||||
return rk_set_reg_speed(bsp_priv, &rk3366_reg_speed_data,
|
||||
RK3366_GRF_SOC_CON6, interface, speed);
|
||||
}
|
||||
|
||||
static const struct rk_gmac_ops rk3366_ops = {
|
||||
.set_to_rgmii = rk3366_set_to_rgmii,
|
||||
.set_to_rmii = rk3366_set_to_rmii,
|
||||
.set_rgmii_speed = rk3366_set_rgmii_speed,
|
||||
.set_rmii_speed = rk3366_set_rmii_speed,
|
||||
.set_speed = rk3366_set_speed,
|
||||
};
|
||||
|
||||
#define RK3368_GRF_SOC_CON15 0x043c
|
||||
|
|
@ -834,29 +756,17 @@ static const struct rk_reg_speed_data rk3368_reg_speed_data = {
|
|||
.rmii_100 = RK3368_GMAC_RMII_CLK_25M | RK3368_GMAC_SPEED_100M,
|
||||
};
|
||||
|
||||
static void rk3368_set_rgmii_speed(struct rk_priv_data *bsp_priv, int speed)
|
||||
static int rk3368_set_speed(struct rk_priv_data *bsp_priv,
|
||||
phy_interface_t interface, int speed)
|
||||
{
|
||||
struct device *dev = &bsp_priv->pdev->dev;
|
||||
|
||||
if (rk_set_reg_speed_rgmii(bsp_priv, &rk3368_reg_speed_data,
|
||||
RK3368_GRF_SOC_CON15, speed))
|
||||
dev_err(dev, "unknown speed value for RGMII! speed=%d", speed);
|
||||
}
|
||||
|
||||
static void rk3368_set_rmii_speed(struct rk_priv_data *bsp_priv, int speed)
|
||||
{
|
||||
struct device *dev = &bsp_priv->pdev->dev;
|
||||
|
||||
if (rk_set_reg_speed_rmii(bsp_priv, &rk3368_reg_speed_data,
|
||||
RK3368_GRF_SOC_CON15, speed))
|
||||
dev_err(dev, "unknown speed value for RMII! speed=%d", speed);
|
||||
return rk_set_reg_speed(bsp_priv, &rk3368_reg_speed_data,
|
||||
RK3368_GRF_SOC_CON15, interface, speed);
|
||||
}
|
||||
|
||||
static const struct rk_gmac_ops rk3368_ops = {
|
||||
.set_to_rgmii = rk3368_set_to_rgmii,
|
||||
.set_to_rmii = rk3368_set_to_rmii,
|
||||
.set_rgmii_speed = rk3368_set_rgmii_speed,
|
||||
.set_rmii_speed = rk3368_set_rmii_speed,
|
||||
.set_speed = rk3368_set_speed,
|
||||
};
|
||||
|
||||
#define RK3399_GRF_SOC_CON5 0xc214
|
||||
|
|
@ -913,29 +823,17 @@ static const struct rk_reg_speed_data rk3399_reg_speed_data = {
|
|||
.rmii_100 = RK3399_GMAC_RMII_CLK_25M | RK3399_GMAC_SPEED_100M,
|
||||
};
|
||||
|
||||
static void rk3399_set_rgmii_speed(struct rk_priv_data *bsp_priv, int speed)
|
||||
static int rk3399_set_speed(struct rk_priv_data *bsp_priv,
|
||||
phy_interface_t interface, int speed)
|
||||
{
|
||||
struct device *dev = &bsp_priv->pdev->dev;
|
||||
|
||||
if (rk_set_reg_speed_rgmii(bsp_priv, &rk3399_reg_speed_data,
|
||||
RK3399_GRF_SOC_CON5, speed))
|
||||
dev_err(dev, "unknown speed value for RGMII! speed=%d", speed);
|
||||
}
|
||||
|
||||
static void rk3399_set_rmii_speed(struct rk_priv_data *bsp_priv, int speed)
|
||||
{
|
||||
struct device *dev = &bsp_priv->pdev->dev;
|
||||
|
||||
if (rk_set_reg_speed_rmii(bsp_priv, &rk3399_reg_speed_data,
|
||||
RK3399_GRF_SOC_CON5, speed))
|
||||
dev_err(dev, "unknown speed value for RMII! speed=%d", speed);
|
||||
return rk_set_reg_speed(bsp_priv, &rk3399_reg_speed_data,
|
||||
RK3399_GRF_SOC_CON5, interface, speed);
|
||||
}
|
||||
|
||||
static const struct rk_gmac_ops rk3399_ops = {
|
||||
.set_to_rgmii = rk3399_set_to_rgmii,
|
||||
.set_to_rmii = rk3399_set_to_rmii,
|
||||
.set_rgmii_speed = rk3399_set_rgmii_speed,
|
||||
.set_rmii_speed = rk3399_set_rmii_speed,
|
||||
.set_speed = rk3399_set_speed,
|
||||
};
|
||||
|
||||
#define RK3528_VO_GRF_GMAC_CON 0x0018
|
||||
|
|
@ -1011,18 +909,9 @@ static const struct rk_reg_speed_data rk3528_gmac1_reg_speed_data = {
|
|||
.rmii_100 = RK3528_GMAC1_CLK_RMII_DIV2,
|
||||
};
|
||||
|
||||
static void rk3528_set_rgmii_speed(struct rk_priv_data *bsp_priv, int speed)
|
||||
static int rk3528_set_speed(struct rk_priv_data *bsp_priv,
|
||||
phy_interface_t interface,int speed)
|
||||
{
|
||||
struct device *dev = &bsp_priv->pdev->dev;
|
||||
|
||||
if (rk_set_reg_speed_rgmii(bsp_priv, &rk3528_gmac1_reg_speed_data,
|
||||
RK3528_VPU_GRF_GMAC_CON5, speed))
|
||||
dev_err(dev, "unknown speed value for RGMII! speed=%d", speed);
|
||||
}
|
||||
|
||||
static void rk3528_set_rmii_speed(struct rk_priv_data *bsp_priv, int speed)
|
||||
{
|
||||
struct device *dev = &bsp_priv->pdev->dev;
|
||||
const struct rk_reg_speed_data *rsd;
|
||||
unsigned int reg;
|
||||
|
||||
|
|
@ -1034,8 +923,7 @@ static void rk3528_set_rmii_speed(struct rk_priv_data *bsp_priv, int speed)
|
|||
reg = RK3528_VO_GRF_GMAC_CON;
|
||||
}
|
||||
|
||||
if (rk_set_reg_speed_rmii(bsp_priv, rsd, reg, speed))
|
||||
dev_err(dev, "unknown speed value for RMII! speed=%d", speed);
|
||||
return rk_set_reg_speed(bsp_priv, rsd, reg, interface, speed);
|
||||
}
|
||||
|
||||
static void rk3528_set_clock_selection(struct rk_priv_data *bsp_priv,
|
||||
|
|
@ -1069,8 +957,7 @@ static void rk3528_integrated_phy_powerdown(struct rk_priv_data *bsp_priv)
|
|||
static const struct rk_gmac_ops rk3528_ops = {
|
||||
.set_to_rgmii = rk3528_set_to_rgmii,
|
||||
.set_to_rmii = rk3528_set_to_rmii,
|
||||
.set_rgmii_speed = rk3528_set_rgmii_speed,
|
||||
.set_rmii_speed = rk3528_set_rmii_speed,
|
||||
.set_speed = rk3528_set_speed,
|
||||
.set_clock_selection = rk3528_set_clock_selection,
|
||||
.integrated_phy_powerup = rk3528_integrated_phy_powerup,
|
||||
.integrated_phy_powerdown = rk3528_integrated_phy_powerdown,
|
||||
|
|
@ -1135,8 +1022,7 @@ static void rk3568_set_to_rmii(struct rk_priv_data *bsp_priv)
|
|||
static const struct rk_gmac_ops rk3568_ops = {
|
||||
.set_to_rgmii = rk3568_set_to_rgmii,
|
||||
.set_to_rmii = rk3568_set_to_rmii,
|
||||
.set_rgmii_speed = rk_set_clk_mac_speed,
|
||||
.set_rmii_speed = rk_set_clk_mac_speed,
|
||||
.set_speed = rk_set_clk_mac_speed,
|
||||
.regs_valid = true,
|
||||
.regs = {
|
||||
0xfe2a0000, /* gmac0 */
|
||||
|
|
@ -1228,17 +1114,16 @@ static const struct rk_reg_speed_data rk3578_reg_speed_data = {
|
|||
.rmii_100 = RK3576_GMAC_CLK_RMII_DIV2,
|
||||
};
|
||||
|
||||
static void rk3576_set_gmac_speed(struct rk_priv_data *bsp_priv, int speed)
|
||||
static int rk3576_set_gmac_speed(struct rk_priv_data *bsp_priv,
|
||||
phy_interface_t interface, int speed)
|
||||
{
|
||||
struct device *dev = &bsp_priv->pdev->dev;
|
||||
unsigned int offset_con;
|
||||
|
||||
offset_con = bsp_priv->id == 1 ? RK3576_GRF_GMAC_CON1 :
|
||||
RK3576_GRF_GMAC_CON0;
|
||||
|
||||
if (rk_set_reg_speed(bsp_priv, &rk3578_reg_speed_data, offset_con,
|
||||
bsp_priv->phy_iface, speed))
|
||||
dev_err(dev, "unknown speed value for GMAC speed=%d", speed);
|
||||
return rk_set_reg_speed(bsp_priv, &rk3578_reg_speed_data, offset_con,
|
||||
interface, speed);
|
||||
}
|
||||
|
||||
static void rk3576_set_clock_selection(struct rk_priv_data *bsp_priv, bool input,
|
||||
|
|
@ -1260,8 +1145,7 @@ static void rk3576_set_clock_selection(struct rk_priv_data *bsp_priv, bool input
|
|||
static const struct rk_gmac_ops rk3576_ops = {
|
||||
.set_to_rgmii = rk3576_set_to_rgmii,
|
||||
.set_to_rmii = rk3576_set_to_rmii,
|
||||
.set_rgmii_speed = rk3576_set_gmac_speed,
|
||||
.set_rmii_speed = rk3576_set_gmac_speed,
|
||||
.set_speed = rk3576_set_gmac_speed,
|
||||
.set_clock_selection = rk3576_set_clock_selection,
|
||||
.php_grf_required = true,
|
||||
.regs_valid = true,
|
||||
|
|
@ -1345,26 +1229,26 @@ static void rk3588_set_to_rmii(struct rk_priv_data *bsp_priv)
|
|||
RK3588_GMAC_CLK_RMII_MODE(bsp_priv->id));
|
||||
}
|
||||
|
||||
static void rk3588_set_gmac_speed(struct rk_priv_data *bsp_priv, int speed)
|
||||
static int rk3588_set_gmac_speed(struct rk_priv_data *bsp_priv,
|
||||
phy_interface_t interface, int speed)
|
||||
{
|
||||
struct device *dev = &bsp_priv->pdev->dev;
|
||||
unsigned int val = 0, id = bsp_priv->id;
|
||||
|
||||
switch (speed) {
|
||||
case 10:
|
||||
if (bsp_priv->phy_iface == PHY_INTERFACE_MODE_RMII)
|
||||
if (interface == PHY_INTERFACE_MODE_RMII)
|
||||
val = RK3588_GMA_CLK_RMII_DIV20(id);
|
||||
else
|
||||
val = RK3588_GMAC_CLK_RGMII_DIV50(id);
|
||||
break;
|
||||
case 100:
|
||||
if (bsp_priv->phy_iface == PHY_INTERFACE_MODE_RMII)
|
||||
if (interface == PHY_INTERFACE_MODE_RMII)
|
||||
val = RK3588_GMA_CLK_RMII_DIV2(id);
|
||||
else
|
||||
val = RK3588_GMAC_CLK_RGMII_DIV5(id);
|
||||
break;
|
||||
case 1000:
|
||||
if (bsp_priv->phy_iface != PHY_INTERFACE_MODE_RMII)
|
||||
if (interface != PHY_INTERFACE_MODE_RMII)
|
||||
val = RK3588_GMAC_CLK_RGMII_DIV1(id);
|
||||
else
|
||||
goto err;
|
||||
|
|
@ -1375,9 +1259,9 @@ static void rk3588_set_gmac_speed(struct rk_priv_data *bsp_priv, int speed)
|
|||
|
||||
regmap_write(bsp_priv->php_grf, RK3588_GRF_CLK_CON1, val);
|
||||
|
||||
return;
|
||||
return 0;
|
||||
err:
|
||||
dev_err(dev, "unknown speed value for GMAC speed=%d", speed);
|
||||
return -EINVAL;
|
||||
}
|
||||
|
||||
static void rk3588_set_clock_selection(struct rk_priv_data *bsp_priv, bool input,
|
||||
|
|
@ -1395,8 +1279,7 @@ static void rk3588_set_clock_selection(struct rk_priv_data *bsp_priv, bool input
|
|||
static const struct rk_gmac_ops rk3588_ops = {
|
||||
.set_to_rgmii = rk3588_set_to_rgmii,
|
||||
.set_to_rmii = rk3588_set_to_rmii,
|
||||
.set_rgmii_speed = rk3588_set_gmac_speed,
|
||||
.set_rmii_speed = rk3588_set_gmac_speed,
|
||||
.set_speed = rk3588_set_gmac_speed,
|
||||
.set_clock_selection = rk3588_set_clock_selection,
|
||||
.php_grf_required = true,
|
||||
.regs_valid = true,
|
||||
|
|
@ -1430,18 +1313,16 @@ static const struct rk_reg_speed_data rv1108_reg_speed_data = {
|
|||
.rmii_100 = RV1108_GMAC_RMII_CLK_25M | RV1108_GMAC_SPEED_100M,
|
||||
};
|
||||
|
||||
static void rv1108_set_rmii_speed(struct rk_priv_data *bsp_priv, int speed)
|
||||
static int rv1108_set_speed(struct rk_priv_data *bsp_priv,
|
||||
phy_interface_t interface, int speed)
|
||||
{
|
||||
struct device *dev = &bsp_priv->pdev->dev;
|
||||
|
||||
if (rk_set_reg_speed_rmii(bsp_priv, &rv1108_reg_speed_data,
|
||||
RV1108_GRF_GMAC_CON0, speed))
|
||||
dev_err(dev, "unknown speed value for RMII! speed=%d", speed);
|
||||
return rk_set_reg_speed(bsp_priv, &rv1108_reg_speed_data,
|
||||
RV1108_GRF_GMAC_CON0, interface, speed);
|
||||
}
|
||||
|
||||
static const struct rk_gmac_ops rv1108_ops = {
|
||||
.set_to_rmii = rv1108_set_to_rmii,
|
||||
.set_rmii_speed = rv1108_set_rmii_speed,
|
||||
.set_speed = rv1108_set_speed,
|
||||
};
|
||||
|
||||
#define RV1126_GRF_GMAC_CON0 0X0070
|
||||
|
|
@ -1499,8 +1380,7 @@ static void rv1126_set_to_rmii(struct rk_priv_data *bsp_priv)
|
|||
static const struct rk_gmac_ops rv1126_ops = {
|
||||
.set_to_rgmii = rv1126_set_to_rgmii,
|
||||
.set_to_rmii = rv1126_set_to_rmii,
|
||||
.set_rgmii_speed = rk_set_clk_mac_speed,
|
||||
.set_rmii_speed = rk_set_clk_mac_speed,
|
||||
.set_speed = rk_set_clk_mac_speed,
|
||||
};
|
||||
|
||||
static int rk_gmac_clk_init(struct plat_stmmacenet_data *plat)
|
||||
|
|
@ -1833,6 +1713,10 @@ static int rk_set_clk_tx_rate(void *bsp_priv_, struct clk *clk_tx_i,
|
|||
struct rk_priv_data *bsp_priv = bsp_priv_;
|
||||
struct device *dev = &bsp_priv->pdev->dev;
|
||||
|
||||
if (bsp_priv->ops->set_speed)
|
||||
return bsp_priv->ops->set_speed(bsp_priv, bsp_priv->phy_iface,
|
||||
speed);
|
||||
|
||||
switch (bsp_priv->phy_iface) {
|
||||
case PHY_INTERFACE_MODE_RGMII:
|
||||
case PHY_INTERFACE_MODE_RGMII_ID:
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user