github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-01 11:03:43 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

serial: 8250_ni: Remove unneeded conditionals

Browse Source 
It doesn't matter if the properties are supplied or not in
the struct ni16550_device_info as default in any case is 0.
Hence there is no need to check for them being set.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: Chaitanya Vadrevu <chaitanya.vadrevu@emerson.com>
Reviewed-by: Chaitanya Vadrevu <chaitanya.vadrevu@emerson.com>
Link: https://lore.kernel.org/r/20250321182119.454507-5-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Andy Shevchenko 2025-03-21 20:20:15 +02:00 committed by Greg Kroah-Hartman
parent b4694a7618
commit 38dbd9517d
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/tty/serial/8250/8250_ni.c
View File

@ -275,7 +275,7 @@ static int ni16550_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
struct uart_8250_port uart = {};
unsigned int txfifosz, rxfifosz;
unsigned int prescaler = 0;
unsigned int prescaler;
struct ni16550_data *data;
const char *portmode;
bool rs232_property;
@ -321,8 +321,7 @@ static int ni16550_probe(struct platform_device *pdev)
* - static declaration in this driver (for older ACPI IDs)
* - a "clock-frequency" ACPI
*/
if (info->uartclk)
uart.port.uartclk = info->uartclk;
uart.port.uartclk = info->uartclk;
ret = uart_read_port_properties(&uart.port);
if (ret)
@ -340,11 +339,9 @@ static int ni16550_probe(struct platform_device *pdev)
goto err;
}
if (info->prescaler)
prescaler = info->prescaler;
prescaler = info->prescaler;
device_property_read_u32(dev, "clock-prescaler", &prescaler);
if (prescaler != 0) {
if (prescaler) {
uart.port.set_mctrl = ni16550_set_mctrl;
ni16550_config_prescaler(&uart, (u8)prescaler);
}