mirror of
https://github.com/torvalds/linux.git
synced 2026-09-12 12:34:02 +02:00
net: phy: dp83867: handle the active-high LED polarity mode
Commita274465cc3("net: phy: support 'active-high' property for PHY LEDs") added PHY_LED_ACTIVE_HIGH and made of_phy_led() set the matching bit in the modes mask when a LED node carries the 'active-high' property. dp83867 was not part of that series. dp83867_led_polarity_set() only recognizes PHY_LED_ACTIVE_LOW, so PHY_LED_ACTIVE_HIGH falls through to the default case and returns -EINVAL. of_phy_led() propagates the error, of_phy_leds() drops the LEDs registered so far and passes it on, and phy_probe() fails. A device tree marking a DP83867 LED as 'active-high', which leds/common.yaml allows and ethernet-phy.yaml references for led@N nodes, thus stops the PHY from probing. Active high is what the function programs when no polarity mode is requested at all, so the initial value of polarity already satisfies the request and only the case label is missing. The same series updated mxl-gpy in commiteb89c79c1b("net: phy: mxl-gpy: correctly describe LED polarity") and aquantia in commit9d55e68b19("net: phy: aquantia: correctly describe LED polarity override"). Fixes:a274465cc3("net: phy: support 'active-high' property for PHY LEDs") Signed-off-by: Donggeun Yoo <donggeunyoo.kernel@gmail.com> Link: https://patch.msgid.link/20260903022839.4006614-1-donggeunyoo.kernel@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
parent
4f4b743c2d
commit
36a45faced
|
|
@ -1150,6 +1150,9 @@ static int dp83867_led_polarity_set(struct phy_device *phydev, int index,
|
|||
case PHY_LED_ACTIVE_LOW:
|
||||
polarity = 0;
|
||||
break;
|
||||
case PHY_LED_ACTIVE_HIGH:
|
||||
polarity = DP83867_LED_POLARITY(index);
|
||||
break;
|
||||
default:
|
||||
return -EINVAL;
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user