github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-29 17:43:52 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

ice: check for PF number outside the fwlog code

Browse Source 
Fwlog can be supported only on PF 0. Check this before calling
init/deinit functions.

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Tested-by: Rinitha S <sx.rinitha@intel.com> (A Contingent worker at Intel)
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
This commit is contained in:
Michal Swiatkowski 2025-08-12 06:23:29 +02:00 committed by Tony Nguyen
parent dc898f7edd
commit 360c46582e
3 changed files with 8 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/net/ethernet/intel/ice/ice_common.c
View File

@ -1002,6 +1002,10 @@ static int __fwlog_init(struct ice_hw *hw)
};
int err;
/* only support fw log commands on PF 0 */
if (hw->bus.func)
return -EINVAL;
err = ice_debugfs_pf_init(pf);
if (err)
return err;
@ -1186,6 +1190,10 @@ int ice_init_hw(struct ice_hw *hw)
static void __fwlog_deinit(struct ice_hw *hw)
{
/* only support fw log commands on PF 0 */
if (hw->bus.func)
return;
ice_debugfs_pf_deinit(hw->back);
ice_fwlog_deinit(hw, &hw->fwlog);
}

4
drivers/net/ethernet/intel/ice/ice_debugfs.c
View File

@ -588,10 +588,6 @@ void ice_debugfs_fwlog_init(struct ice_pf *pf)
struct dentry **fw_modules;
int i;
/* only support fw log commands on PF 0 */
if (pf->hw.bus.func)
return;
/* allocate space for this first because if it fails then we don't
* need to unwind
*/

8
drivers/net/ethernet/intel/ice/ice_fwlog.c
View File

@ -242,10 +242,6 @@ static void ice_fwlog_set_supported(struct ice_fwlog *fwlog)
int ice_fwlog_init(struct ice_hw *hw, struct ice_fwlog *fwlog,
struct ice_fwlog_api *api)
{
/* only support fw log commands on PF 0 */
if (hw->bus.func)
return -EINVAL;
fwlog->api = *api;
ice_fwlog_set_supported(fwlog);
@ -296,10 +292,6 @@ void ice_fwlog_deinit(struct ice_hw *hw, struct ice_fwlog *fwlog)
struct ice_pf *pf = hw->back;
int status;
/* only support fw log commands on PF 0 */
if (hw->bus.func)
return;
/* make sure FW logging is disabled to not put the FW in a weird state
* for the next driver load
*/