From 356abf7cedff742621c9b7ae8ecfa7d0febb0b9e Mon Sep 17 00:00:00 2001 From: Fuad Tabba Date: Mon, 17 Aug 2026 10:27:05 +0100 Subject: [PATCH] KVM: arm64: vgic-its: Reword the comment on a collection-less ITE The comment above the NULL collection check in vgic_its_save_ite() names only MAPC with V=0, which is UNPREDICTABLE. The route that requires the check is clearing GITS_BASER.Valid on a disabled ITS, a legitimate operation that orphans every ITE at once. Name both routes. No functional change intended. Suggested-by: Eric Auger Link: https://lore.kernel.org/all/0ce5e496-a067-48fd-80d2-94fe9981d505@redhat.com/ Signed-off-by: Fuad Tabba Reviewed-by: Eric Auger Link: https://patch.msgid.link/20260817092705.1112634-1-fuad.tabba@linux.dev Signed-off-by: Marc Zyngier --- arch/arm64/kvm/vgic/vgic-its.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/kvm/vgic/vgic-its.c b/arch/arm64/kvm/vgic/vgic-its.c index 9e782a4fea7e..9ceecb45995a 100644 --- a/arch/arm64/kvm/vgic/vgic-its.c +++ b/arch/arm64/kvm/vgic/vgic-its.c @@ -2121,9 +2121,9 @@ static int vgic_its_save_ite(struct vgic_its *its, struct its_device *dev, u64 val; /* - * MAPC with V=0 keeps the ITEs mapped but drops their collection, - * and with it the ICID. Save a zeroed entry, which the restore path - * reads back as invalid. + * MAPC with V=0 and clearing GITS_BASER.Valid both keep the + * ITEs mapped while dropping their collection, and with it the ICID. + * Save a zeroed entry, which the restore path reads back as invalid. */ if (!ite->collection) return vgic_its_write_entry_lock(its, gpa, 0ULL, ite);