github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-07-28 01:55:51 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

ASoC: simple-amplifier: Use 'simple_amp' variable name instead of 'priv'

Browse Source 
The simple-amplifier driver use 'priv' as variable name for its private
data (struct simple_amp).

With the support for gpio-audio-amp, more functions and data
structures will be added.

Those future additions will add more complexity in data manipulation and
will make the 'priv' term error prone.

In order to clearly identify the struct simple_amp private data, use
'simple_amp' as variable name when this structure is involved.

Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Link: https://patch.msgid.link/20260513081702.317117-8-herve.codina@bootlin.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Herve Codina 2026-05-13 10:16:51 +02:00 committed by Mark Brown
parent dc8beaad29
commit 34ddd2d368
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
sound/soc/codecs/simple-amplifier.c
View File

@ -19,7 +19,7 @@ static int simple_amp_power_event(struct snd_soc_dapm_widget *w,
struct snd_kcontrol *control, int event)
{
struct snd_soc_component *c = snd_soc_dapm_to_component(w->dapm);
struct simple_amp *priv = snd_soc_component_get_drvdata(c);
struct simple_amp *simple_amp = snd_soc_component_get_drvdata(c);
int val;
switch (event) {
@ -34,7 +34,7 @@ static int simple_amp_power_event(struct snd_soc_dapm_widget *w,
return -EINVAL;
}
gpiod_set_value_cansleep(priv->gpiod_enable, val);
gpiod_set_value_cansleep(simple_amp->gpiod_enable, val);
return 0;
}
@ -68,17 +68,17 @@ static const struct snd_soc_component_driver simple_amp_component_driver = {
static int simple_amp_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
struct simple_amp *priv;
struct simple_amp *simple_amp;
priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
if (priv == NULL)
simple_amp = devm_kzalloc(dev, sizeof(*simple_amp), GFP_KERNEL);
if (!simple_amp)
return -ENOMEM;
platform_set_drvdata(pdev, priv);
platform_set_drvdata(pdev, simple_amp);
priv->gpiod_enable = devm_gpiod_get_optional(dev, "enable",
GPIOD_OUT_LOW);
if (IS_ERR(priv->gpiod_enable))
return dev_err_probe(dev, PTR_ERR(priv->gpiod_enable),
simple_amp->gpiod_enable = devm_gpiod_get_optional(dev, "enable",
GPIOD_OUT_LOW);
if (IS_ERR(simple_amp->gpiod_enable))
return dev_err_probe(dev, PTR_ERR(simple_amp->gpiod_enable),
"Failed to get 'enable' gpio");
return devm_snd_soc_register_component(dev,