github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-07-31 11:37:06 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

sched/walt/halt: ra-arrange the code

Browse Source 
re-arrange the code to avoid following issues:

1. Mark walt_drain_thread as RT thread with highest priority to avoid
getting preempted by other tasks in the system.

2. Handle kthread_should_stop() in walt_drain_thread.

Change-Id: I404674477948626503742a66fce657070b89b9e6
Signed-off-by: Satya Durga Srinivasu Prabhala <quic_satyap@quicinc.com>
Signed-off-by: Stephen Dickey <quic_dickey@quicinc.com>
This commit is contained in:
Satya Durga Srinivasu Prabhala 2022-04-06 11:36:42 -07:00 committed by Rishabh Bhatnagar
parent 851ffc330b
commit 3482549d47
1 changed files with 30 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
kernel/sched/walt/walt_halt.c
View File

@ -190,10 +190,10 @@ static int drain_rq_cpu_stop(void *data)
static int cpu_drain_rq(unsigned int cpu)
{
if (available_idle_cpu(cpu))
if (!cpu_online(cpu))
return 0;
if (!cpu_online(cpu))
if (available_idle_cpu(cpu))
return 0;
/* this will schedule, must not be in atomic context */
@ -229,26 +229,26 @@ static int __ref try_drain_rqs(void *data)
int cpu;
unsigned long flags;
raw_spin_lock_irqsave(&walt_drain_pending_lock, flags);
/* continue while there are cpus to drain
* assume at least one cpu to start.
*/
do {
cpumask_t local_cpus;
cpumask_copy(&local_cpus, cpus_ptr);
raw_spin_unlock_irqrestore(&walt_drain_pending_lock, flags);
for_each_cpu(cpu, &local_cpus)
cpu_drain_rq(cpu);
while (!kthread_should_stop()) {
raw_spin_lock_irqsave(&walt_drain_pending_lock, flags);
cpumask_andnot(cpus_ptr, cpus_ptr, &local_cpus);
if (cpumask_weight(cpus_ptr)) {
cpumask_t local_cpus;
} while (cpumask_weight(cpus_ptr));
cpumask_copy(&local_cpus, cpus_ptr);
raw_spin_unlock_irqrestore(&walt_drain_pending_lock, flags);
raw_spin_unlock_irqrestore(&walt_drain_pending_lock, flags);
for_each_cpu(cpu, &local_cpus)
cpu_drain_rq(cpu);
raw_spin_lock_irqsave(&walt_drain_pending_lock, flags);
cpumask_andnot(cpus_ptr, cpus_ptr, &local_cpus);
}
raw_spin_unlock_irqrestore(&walt_drain_pending_lock, flags);
set_current_state(TASK_INTERRUPTIBLE);
schedule();
set_current_state(TASK_RUNNING);
}
return 0;
}
@ -286,7 +286,9 @@ static int halt_cpus(struct cpumask *cpus)
raw_spin_lock_irqsave(&walt_drain_pending_lock, flags);
cpumask_or(&drain_data.cpus_to_drain, &drain_data.cpus_to_drain, cpus);
raw_spin_unlock_irqrestore(&walt_drain_pending_lock, flags);
wake_up_process(walt_drain_thread);
if (!IS_ERR(walt_drain_thread))
wake_up_process(walt_drain_thread);
trace_halt_cpus(cpus, start_time, 1, ret);
@ -386,7 +388,6 @@ int walt_halt_cpus(struct cpumask *cpus)
return ret;
}
EXPORT_SYMBOL(walt_halt_cpus);
int walt_pause_cpus(struct cpumask *cpus)
{
@ -421,7 +422,6 @@ int walt_start_cpus(struct cpumask *cpus)
return ret;
}
EXPORT_SYMBOL(walt_start_cpus);
int walt_resume_cpus(struct cpumask *cpus)
{
@ -523,7 +523,15 @@ static void android_rvh_is_cpu_allowed(void *unused, int cpu, bool *allowed)
void walt_halt_init(void)
{
struct sched_param param = { .sched_priority = MAX_RT_PRIO-1 };
walt_drain_thread = kthread_run(try_drain_rqs, &drain_data, "halt_drain_rqs");
if (IS_ERR(walt_drain_thread)) {
pr_err("Error creating walt drain thread\n");
return;
}
sched_setscheduler_nocheck(walt_drain_thread, SCHED_FIFO, &param);
register_trace_android_rvh_get_nohz_timer_target(android_rvh_get_nohz_timer_target, NULL);
register_trace_android_rvh_set_cpus_allowed_ptr_locked(