github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-04 12:35:52 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

staging: vme_user: Use dev_err() in vme_check_window()

Browse Source 
vme_check_window() uses printk() for logging error message. This
leads to the following checkpatch warning:
   WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then
            dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...

Use dev_err() instead. Pass VME bridge device to vme_check_window() so
that the error message can be logged with the bridge device context.

Signed-off-by: Soumya Negi <soumya.negi97@gmail.com>
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/221344ede933b1d9e6c31310b0f4dbb8be809c86.1697763267.git.soumya.negi97@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Soumya Negi 2023-10-19 18:55:23 -07:00 committed by Greg Kroah-Hartman
parent c6054f43f7
commit 3249888c1b
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/staging/vme_user/vme.c
View File

@ -160,8 +160,8 @@ size_t vme_get_size(struct vme_resource *resource)
}
EXPORT_SYMBOL(vme_get_size);
int vme_check_window(u32 aspace, unsigned long long vme_base,
unsigned long long size)
int vme_check_window(struct vme_bridge *bridge, u32 aspace,
unsigned long long vme_base, unsigned long long size)
{
int retval = 0;
@ -195,7 +195,7 @@ int vme_check_window(u32 aspace, unsigned long long vme_base,
/* User Defined */
break;
default:
printk(KERN_ERR "Invalid address space\n");
dev_err(bridge->parent, "Invalid address space\n");
retval = -EINVAL;
break;
}
@ -350,7 +350,7 @@ int vme_slave_set(struct vme_resource *resource, int enabled,
return -EINVAL;
}
retval = vme_check_window(aspace, vme_base, size);
retval = vme_check_window(bridge, aspace, vme_base, size);
if (retval)
return retval;
@ -552,7 +552,7 @@ int vme_master_set(struct vme_resource *resource, int enabled,
return -EINVAL;
}
retval = vme_check_window(aspace, vme_base, size);
retval = vme_check_window(bridge, aspace, vme_base, size);
if (retval)
return retval;

4
drivers/staging/vme_user/vme.h
View File

@ -133,8 +133,8 @@ void vme_free_consistent(struct vme_resource *, size_t, void *,
dma_addr_t);
size_t vme_get_size(struct vme_resource *);
int vme_check_window(u32 aspace, unsigned long long vme_base,
unsigned long long size);
int vme_check_window(struct vme_bridge *bridge, u32 aspace,
unsigned long long vme_base, unsigned long long size);
struct vme_resource *vme_slave_request(struct vme_dev *, u32, u32);
int vme_slave_set(struct vme_resource *, int, unsigned long long,