github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-28 17:13:52 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

eth: fbnic: Remove retry support

Browse Source 
The driver retries sensor read requests from firmware, but this is
unnecessary. A functioning firmware should respond to each request
within the timeout period. Remove the retry logic and set the timeout
to the sum of all retry timeouts.

Signed-off-by: Mohsin Bashir <mohsin.bashr@gmail.com>
Link: https://patch.msgid.link/20260115003353.4150771-5-mohsin.bashr@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Mohsin Bashir 2026-01-14 16:33:52 -08:00 committed by Jakub Kicinski
parent 301ae0d539
commit 320ee20a0b
1 changed files with 5 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
drivers/net/ethernet/meta/fbnic/fbnic_mac.c
View File

@ -835,7 +835,7 @@ static int fbnic_mac_get_sensor_asic(struct fbnic_dev *fbd, int id,
long *val)
{
struct fbnic_fw_completion *fw_cmpl;
int err = 0, retries = 5;
int err = 0;
s32 *sensor;
fw_cmpl = fbnic_fw_alloc_cmpl(FBNIC_TLV_MSG_ID_TSENE_READ_RESP);
@ -862,24 +862,10 @@ static int fbnic_mac_get_sensor_asic(struct fbnic_dev *fbd, int id,
goto exit_free;
}
/* Allow 2 seconds for reply, resend and try up to 5 times */
while (!wait_for_completion_timeout(&fw_cmpl->done, 2 * HZ)) {
retries--;
if (retries == 0) {
dev_err(fbd->dev,
"Timed out waiting for TSENE read\n");
err = -ETIMEDOUT;
goto exit_cleanup;
}
err = fbnic_fw_xmit_tsene_read_msg(fbd, NULL);
if (err) {
dev_err(fbd->dev,
"Failed to transmit TSENE read msg, err %d\n",
err);
goto exit_cleanup;
}
if (!wait_for_completion_timeout(&fw_cmpl->done, 10 * HZ)) {
dev_err(fbd->dev, "Timed out waiting for TSENE read\n");
err = -ETIMEDOUT;
goto exit_cleanup;
}
/* Handle error returned by firmware */