github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-11-07 06:17:02 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

selftests: ALSA: pcmtest: Check the frame count of each transfer

Browse Source 
The tests keep the result of snd_pcm_writei(), snd_pcm_readi() and
their non-interleaved forms in a size_t. A size_t is never negative, so
ASSERT_GE(res, 0) always passes.

The capture tests still catch a failed read when they compare the data.
But the playback tests do not. The driver sets pc_test to 1 when it saw
no corrupted data, and that is also true when it saw no data at all. So
a playback test passes even when every write fails.

Store the result as snd_pcm_sframes_t and check that the whole request
was transferred. The calls block, so a short count means an error.

Fixes: 10b98a4db1 ("selftests: ALSA: Add test for the 'pcmtest' driver")
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: HyeongJun An <sammiee5311@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/6f16e2a01f18c0ea069164bab31999182ff6d49e.1792390197.git.sammiee5311@gmail.com
This commit is contained in:
HyeongJun An 2026-10-20 19:18:36 +09:00 committed by Takashi Iwai
parent ecefaa2dc0
commit 317f2ddb66
1 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
tools/testing/selftests/alsa/test-pcmtest-driver.c
View File

@ -166,7 +166,7 @@ FIXTURE_SETUP(pcmtest) {
TEST_F(pcmtest, playback) {
snd_pcm_t *handle;
unsigned char *it;
size_t write_res;
snd_pcm_sframes_t write_res;
int test_results;
int i, cur_ch, pos_in_ch;
void *samples;
@ -190,7 +190,7 @@ TEST_F(pcmtest, playback) {
it[i] = patterns[cur_ch].buf[pos_in_ch % patterns[cur_ch].len];
}
write_res = snd_pcm_writei(handle, samples, params->rate * params->time);
ASSERT_GE(write_res, 0);
ASSERT_EQ(write_res, params->rate * params->time);
snd_pcm_close(handle);
free(samples);
@ -206,7 +206,7 @@ TEST_F(pcmtest, playback) {
TEST_F(pcmtest, capture) {
snd_pcm_t *handle;
unsigned char *it;
size_t read_res;
snd_pcm_sframes_t read_res;
int i, cur_ch, pos_in_ch;
void *samples;
struct pcmtest_test_params *params = &self->params;
@ -222,7 +222,7 @@ TEST_F(pcmtest, capture) {
snd_pcm_format_set_silence(params->format, samples,
params->rate * params->channels * params->time);
read_res = snd_pcm_readi(handle, samples, params->rate * params->time);
ASSERT_GE(read_res, 0);
ASSERT_EQ(read_res, params->rate * params->time);
snd_pcm_close(handle);
it = (unsigned char *)samples;
for (i = 0; i < self->params.sec_buf_len * self->params.time; i++) {
@ -239,7 +239,8 @@ TEST_F(pcmtest, ni_capture) {
snd_pcm_t *handle;
struct pcmtest_test_params params = self->params;
char **chan_samples;
size_t i, j, read_res;
snd_pcm_sframes_t read_res;
size_t i, j;
chan_samples = calloc(CH_NUM, sizeof(*chan_samples));
ASSERT_NE(chan_samples, NULL);
@ -257,7 +258,7 @@ TEST_F(pcmtest, ni_capture) {
for (i = 0; i < 1; i++) {
read_res = snd_pcm_readn(handle, (void **)chan_samples, params.rate * params.time);
ASSERT_GE(read_res, 0);
ASSERT_EQ(read_res, params.rate * params.time);
}
snd_pcm_close(handle);
@ -273,7 +274,8 @@ TEST_F(pcmtest, ni_playback) {
snd_pcm_t *handle;
struct pcmtest_test_params params = self->params;
char **chan_samples;
size_t i, j, read_res;
snd_pcm_sframes_t write_res;
size_t i, j;
int test_res;
chan_samples = calloc(CH_NUM, sizeof(*chan_samples));
@ -294,8 +296,9 @@ TEST_F(pcmtest, ni_playback) {
}
for (i = 0; i < 1; i++) {
read_res = snd_pcm_writen(handle, (void **)chan_samples, params.rate * params.time);
ASSERT_GE(read_res, 0);
write_res = snd_pcm_writen(handle, (void **)chan_samples,
params.rate * params.time);
ASSERT_EQ(write_res, params.rate * params.time);
}
snd_pcm_close(handle);