github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-07 05:55:44 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

staging: wfx: simplify wfx_upload_ap_templates()

Browse Source 
This function built probe response from data retrieved in beacon. Yet,
this job can be done with ieee80211_proberesp_get(). So, we can simplify
that code (and fix bugs like inclusion of TIM in probe responses).

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Link: https://lore.kernel.org/r/20200115135338.14374-18-Jerome.Pouiller@silabs.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Jérôme Pouiller 2020-01-15 13:54:26 +00:00 committed by Greg Kroah-Hartman
parent d8a92d9186
commit 305f710995
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/staging/wfx/sta.c
View File

@ -783,7 +783,6 @@ static int wfx_update_beaconing(struct wfx_vif *wvif)
static int wfx_upload_ap_templates(struct wfx_vif *wvif)
{
struct sk_buff *skb;
struct ieee80211_mgmt *mgmt;
if (wvif->vif->type == NL80211_IFTYPE_STATION ||
wvif->vif->type == NL80211_IFTYPE_MONITOR ||
@ -795,14 +794,11 @@ static int wfx_upload_ap_templates(struct wfx_vif *wvif)
return -ENOMEM;
hif_set_template_frame(wvif, skb, HIF_TMPLT_BCN,
API_RATE_INDEX_B_1MBPS);
dev_kfree_skb(skb);
/* TODO: Distill probe resp; remove TIM and any other beacon-specific
* IEs
*/
mgmt = (void *)skb->data;
mgmt->frame_control =
cpu_to_le16(IEEE80211_FTYPE_MGMT | IEEE80211_STYPE_PROBE_RESP);
skb = ieee80211_proberesp_get(wvif->wdev->hw, wvif->vif);
if (!skb)
return -ENOMEM;
hif_set_template_frame(wvif, skb, HIF_TMPLT_PRBRES,
API_RATE_INDEX_B_1MBPS);
dev_kfree_skb(skb);