selftests/damon: prevent remaining cross-object state pollution

_damon_sysfs.py defines constructors with mutable default arguments,
including DamosAccessPattern(), DamosQuota(), DamosWatermarks(),
DamosDests(), IntervalsGoal(), and empty lists.

Default arguments are evaluated once at function definition time.  Damos()
instances created without explicit arguments therefore share the same
DamosQuota(), and the other default-constructed sub-objects and lists are
shared in the same way.  The sub-objects keep back-pointers to their owner
scheme, so constructing the second Damos() rebinds the shared quota's
scheme pointer to the second object.  An item appended to one object's
default contexts or filters list is also visible from other
default-constructed objects.

The shared state can corrupt test configurations.  DamosQuota.sysfs_dir()
derives the sysfs directory from its scheme pointer, so operating on the
first scheme's default quota may write to the second scheme's directory. 
The wrong values often match the defaults, so tests still pass, but the
behavior depends on object creation order.

Commit 8319dadcbd ("selftests/damon: prevent cross-context state
pollution in DamonCtx") fixed the same pattern in DamonCtx only.  Fix the
remaining constructors by defaulting to None and creating fresh objects or
lists inside each constructor.  Explicit arguments keep their previous
behavior.

Link: https://lore.kernel.org/20260831142611.77572-7-sj@kernel.org
Signed-off-by: zhaozhengzhuo <zhaozhengzhuo@uniontech.com>
Signed-off-by: SJ Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: SJ Park <sj@kernel.org>
Cc: Enze Li <lienze@kylinos.cn>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Hari Mishal <harimishal1@gmail.com>
Cc: Jaeyeon Lee <jaeyeon.lee.dev@gmail.com>
Cc: Li Youhong <liyouhong@kylinos.cn>
Cc: Shuah Khan <shuah@kernel.org>
Cc: "Zenghui Yu (Huawei)" <zenghui.yu@linux.dev>
This commit is contained in:
zhaozhengzhuo 2026-08-31 07:26:08 -07:00 committed by Andrew Morton
parent a861a1dbfa
commit 3009b0a76c

View File

@ -321,8 +321,10 @@ class DamosFilters:
filters = None
scheme = None # owner scheme
def __init__(self, name, filters=[]):
def __init__(self, name, filters=None):
self.name = name
if filters is None:
filters = []
self.filters = filters
for idx, filter_ in enumerate(self.filters):
filter_.idx = idx
@ -368,7 +370,9 @@ class DamosDests:
dests = None
scheme = None # owner scheme
def __init__(self, dests=[]):
def __init__(self, dests=None):
if dests is None:
dests = []
self.dests = dests
for idx, dest in enumerate(self.dests):
dest.idx = idx
@ -426,15 +430,21 @@ class Damos:
stats = None
tried_regions = None
def __init__(self, action='stat', access_pattern=DamosAccessPattern(),
quota=DamosQuota(), watermarks=DamosWatermarks(),
core_filters=[], ops_filters=[], filters=[], target_nid=0,
dests=DamosDests(), apply_interval_us=0):
def __init__(self, action='stat', access_pattern=None, quota=None,
watermarks=None, core_filters=None, ops_filters=None,
filters=None, target_nid=0, dests=None,
apply_interval_us=0):
self.action = action
if access_pattern is None:
access_pattern = DamosAccessPattern()
self.access_pattern = access_pattern
self.access_pattern.scheme = self
if quota is None:
quota = DamosQuota()
self.quota = quota
self.quota.scheme = self
if watermarks is None:
watermarks = DamosWatermarks()
self.watermarks = watermarks
self.watermarks.scheme = self
@ -448,6 +458,8 @@ class Damos:
self.filters.scheme = self
self.target_nid = target_nid
if dests is None:
dests = DamosDests()
self.dests = dests
self.dests.scheme = self
@ -568,10 +580,12 @@ class DamonAttrs:
context = None
def __init__(self, sample_us=5000, aggr_us=100000,
intervals_goal=IntervalsGoal(), update_us=1000000,
min_nr_regions=10, max_nr_regions=1000):
intervals_goal=None, update_us=1000000, min_nr_regions=10,
max_nr_regions=1000):
self.sample_us = sample_us
self.aggr_us = aggr_us
if intervals_goal is None:
intervals_goal = IntervalsGoal()
self.intervals_goal = intervals_goal
self.intervals_goal.attrs = self
self.update_us = update_us
@ -703,7 +717,9 @@ class Kdamond:
idx = None # index of this kdamond between siblings
kdamonds = None # parent
def __init__(self, contexts=[], refresh_ms=None):
def __init__(self, contexts=None, refresh_ms=None):
if contexts is None:
contexts = []
self.contexts = contexts
self.refresh_ms = refresh_ms
for idx, context in enumerate(self.contexts):
@ -853,7 +869,9 @@ class Kdamond:
class Kdamonds:
kdamonds = []
def __init__(self, kdamonds=[]):
def __init__(self, kdamonds=None):
if kdamonds is None:
kdamonds = []
self.kdamonds = kdamonds
for idx, kdamond in enumerate(self.kdamonds):
kdamond.idx = idx