github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-11-10 17:11:02 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

media: i2c: it6625: use early returns in it6625_update_timings_if_changed()

Browse Source 
Convert the if/else if/else chain that only ever assigns a single
ret value to early returns. guard(mutex)(...) is scoped to the whole
function body, so an early return still unlocks correctly.

Signed-off-by: Hermes Wu <Hermes.wu@ite.com.tw>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
This commit is contained in:
Hermes Wu 2026-09-30 14:41:33 +08:00 committed by Hans Verkuil
parent 2a1247ebf8
commit 2f7dc82ea9
1 changed files with 9 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
drivers/media/i2c/it6625.c
View File

@ -1457,20 +1457,17 @@ static int
it6625_update_timings_if_changed(struct it6625 *it6625,
const struct v4l2_dv_timings *timings)
{
int ret;
guard(mutex)(&it6625->it6625_lock);
if (v4l2_match_dv_timings(&it6625->timings, timings, 0, false)) {
ret = 0;
} else if (!v4l2_valid_dv_timings(timings, it6625_get_timings_cap(it6625),
NULL, NULL)) {
ret = -ERANGE;
} else {
it6625->timings = *timings;
ret = 1;
}
return ret;
if (v4l2_match_dv_timings(&it6625->timings, timings, 0, false))
return 0;
if (!v4l2_valid_dv_timings(timings, it6625_get_timings_cap(it6625), NULL, NULL))
return -ERANGE;
it6625->timings = *timings;
return 1;
}
static int it6625_enum_dv_timings(struct v4l2_subdev *sd,