github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-30 10:04:04 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

selftests: fib rule: Drop erroneous TABLE variable

Browse Source 
The fib_rule6_del_by_pref() and fib_rule4_del_by_pref() functions use
an uninitialised $TABLE variable. They should use $RTABLE instead.
This doesn't alter the result of the test, as it just makes the grep
command less specific (but since the script always uses the same table
number, that doesn't really matter).

Let's fix it anyway and, while there, specify the filtering parameters
directly in 'ip -X rule show' to avoid the extra grep command entirely.

Signed-off-by: Guillaume Nault <gnault@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Guillaume Nault 2022-01-31 16:42:04 +01:00 committed by David S. Miller
parent 8af2ba9a78
commit 2e25211363
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tools/testing/selftests/net/fib_rule_tests.sh
View File

@ -96,7 +96,7 @@ fib_rule6_del()
fib_rule6_del_by_pref()
{
pref=$($IP -6 rule show | grep "$1 lookup $TABLE" | cut -d ":" -f 1)
pref=$($IP -6 rule show $1 table $RTABLE | cut -d ":" -f 1)
$IP -6 rule del pref $pref
}
@ -168,7 +168,7 @@ fib_rule4_del()
fib_rule4_del_by_pref()
{
pref=$($IP rule show | grep "$1 lookup $TABLE" | cut -d ":" -f 1)
pref=$($IP rule show $1 table $RTABLE | cut -d ":" -f 1)
$IP rule del pref $pref
}