github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-29 17:43:52 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

phy: lynx-28g: avoid memsetting lane already allocated with kzalloc()

Browse Source 
"priv" is allocated by lynx_28g_probe() using devm_kzalloc(), and the
lane is memory inside that structure (&priv->lane[id]). We don't have to
zero-initialize it, it is already filled with zeroes.

Suggested-by: Vinod Koul <vkoul@kernel.org>
Link: https://lore.kernel.org/linux-phy/aRYMM3ZuyBYH8zEC@vaman/
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Link: https://patch.msgid.link/20251125114847.804961-5-vladimir.oltean@nxp.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Vladimir Oltean 2025-11-25 13:48:36 +02:00 committed by Vinod Koul
parent 7df7d58abb
commit 2da0b2214f
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/phy/freescale/phy-fsl-lynx-28g.c
View File

@ -592,8 +592,6 @@ static int lynx_28g_probe_lane(struct lynx_28g_priv *priv, int id,
struct lynx_28g_lane *lane = &priv->lane[id];
struct phy *phy;
memset(lane, 0, sizeof(*lane));
phy = devm_phy_create(priv->dev, dn, &lynx_28g_ops);
if (IS_ERR(phy))
return PTR_ERR(phy);