From 6cea839b2de04818e1b638b68993a1b94eb17081 Mon Sep 17 00:00:00 2001 From: Haiyue Wang Date: Thu, 29 Oct 2026 10:12:30 +0800 Subject: [PATCH 1/2] platform: arm64: drop the vacuous THERMAL dependency from EC_ASUS_GLYMUR MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 'depends on THERMAL || THERMAL=n' is always true and is semantically a no-op, but it couples NEW_LEDS, which is selected here, to THERMAL and closes a Kconfig dependency loop. The C tools stay silent because they fold the always-true expression to 'y' before running dependency loop detection; kconfiglib, used by the Yocto kernel config audit, does not fold and rejects the config at parse time. The loop is easy to expose with the in-tree tools, using the technique from commit b33a654a5bd6 ("drm/tiny: Kconfig: Remove always-y THERMAL dep. from TINYDRM_REPAPER"), https://git.kernel.org/linus/b33a654a5bd6: temporarily make THERMAL tristate so the folding stops, then any config target reports it: $ sed -i 's/bool "Thermal drivers"/tristate "Thermal drivers"/' \ drivers/thermal/Kconfig $ make allnoconfig error: recursive dependency detected! symbol POWER_SUPPLY is selected by HID_ASUS symbol HID_ASUS depends on LEDS_CLASS symbol LEDS_CLASS depends on NEW_LEDS symbol NEW_LEDS is selected by EC_ASUS_GLYMUR symbol EC_ASUS_GLYMUR depends on THERMAL symbol THERMAL is selected by AB8500_BM symbol AB8500_BM depends on POWER_SUPPLY Drop the vacuous line to break the loop; the driver still builds both with and without THERMAL. Fixes: db3a9dddab5f ("platform: arm64: Add a driver for the EC found on ASUS Glymur machines") Signed-off-by: Haiyue Wang Assisted-by: LLM Reviewed-by: Konrad Dybcio Link: https://patch.msgid.link/20261029021330.460192-1-haiyuewa@163.com Reviewed-by: Ilpo Järvinen Signed-off-by: Ilpo Järvinen --- drivers/platform/arm64/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/platform/arm64/Kconfig b/drivers/platform/arm64/Kconfig index 2a84775a13a9..3f879410b311 100644 --- a/drivers/platform/arm64/Kconfig +++ b/drivers/platform/arm64/Kconfig @@ -40,7 +40,6 @@ config EC_ASUS_GLYMUR depends on HWMON depends on INPUT depends on PM - depends on THERMAL || THERMAL=n select NEW_LEDS select LEDS_CLASS help From 086aeca907789bd2604f16f07bfc073b19015015 Mon Sep 17 00:00:00 2001 From: Armin Wolf Date: Fri, 30 Oct 2026 20:46:44 +0100 Subject: [PATCH 2/2] platform/x86: uniwill-laptop: Implement .hw_offloaded trigger callback MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Since commit 8e04e5382aa9 ("leds: trigger: Add hw_offloaded() callback and provide trigger_may_offload_to_hw attribute") the LED subsystem allows triggers to report if they are being offloaded to the underlying hardware. Implement the necessary callback so that the LED subsystem knows that the lightbar trigger is always offloaded to hardware. Fixes: d1c0c8996977 ("platform/x86: uniwill-laptop: Implement rainbow animation as trigger") Signed-off-by: Armin Wolf Link: https://patch.msgid.link/20261030194704.424388-1-W_Armin@gmx.de Reviewed-by: Ilpo Järvinen Signed-off-by: Ilpo Järvinen --- drivers/platform/x86/uniwill/uniwill-acpi.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/platform/x86/uniwill/uniwill-acpi.c b/drivers/platform/x86/uniwill/uniwill-acpi.c index f62d59f29676..ee444577e691 100644 --- a/drivers/platform/x86/uniwill/uniwill-acpi.c +++ b/drivers/platform/x86/uniwill/uniwill-acpi.c @@ -1543,12 +1543,18 @@ static void uniwill_lightbar_trigger_deactivate(struct led_classdev *led_cdev) dev_err(led_cdev->dev, "Failed to stop rainbow animation: %d\n", ret); } +static bool uniwill_lightbar_trigger_hw_offloaded(struct led_classdev *led_cdev) +{ + return true; +} + static struct led_hw_trigger_type uniwill_lightbar_trigger_type; static struct led_trigger uniwill_lightbar_trigger = { .name = "uniwill-rainbow", .activate = uniwill_lightbar_trigger_activate, .deactivate = uniwill_lightbar_trigger_deactivate, + .hw_offloaded = uniwill_lightbar_trigger_hw_offloaded, .trigger_type = &uniwill_lightbar_trigger_type, };