github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-07-27 17:47:41 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

net: thunderx: fix PTP device ref leak in nicvf_probe()

Browse Source 
cavium_ptp_get() acquires a reference to the PTP PCI device
through pci_get_device(). If any initialization step fails
after cavium_ptp_get(), the PTP PCI device reference is leaked.
Add a common error path to release the PTP reference before
returning from probe failures.

Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
Link: https://patch.msgid.link/20260525082611.61817-1-lihaoxiang@isrc.iscas.ac.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Haoxiang Li 2026-05-25 16:26:11 +08:00 committed by Jakub Kicinski
parent 46d111a3ef
commit 2bcf59eefb
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/net/ethernet/cavium/thunder/nicvf_main.c
View File

@ -2109,8 +2109,10 @@ static int nicvf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
}
err = pci_enable_device(pdev);
if (err)
return dev_err_probe(dev, err, "Failed to enable PCI device\n");
if (err) {
err = dev_err_probe(dev, err, "Failed to enable PCI device\n");
goto err_put_ptp;
}
err = pci_request_regions(pdev, DRV_NAME);
if (err) {
@ -2264,6 +2266,8 @@ static int nicvf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
pci_release_regions(pdev);
err_disable_device:
pci_disable_device(pdev);
err_put_ptp:
cavium_ptp_put(ptp_clock);
return err;
}