From 2b4bcdd40ca00695ed21980f3bc7860823d1423e Mon Sep 17 00:00:00 2001 From: Dmitry Torokhov Date: Thu, 8 Oct 2026 02:47:34 -0700 Subject: [PATCH] Input: tps6507x-ts - fix input device parent assignment Assigning the MFD parent device (tsc->dev) instead of the platform device (&pdev->dev) as the parent device after devm_input_allocate_device(&pdev->dev) splits devres management across two devices. As a result, input_register_device() attaches the devm unregistration action to the MFD parent device rather than the platform device, leaving the input device registered when the platform driver unbinds. devm_input_allocate_device(&pdev->dev) already sets input_dev->dev.parent to &pdev->dev. Drop the redundant and erroneous assignment. Fixes: 2e2a0db8c88d ("Input: tps6507x-ts - update to devm_* API") Assisted-by: LLM Link: https://patch.msgid.link/20261008094736.918137-4-dmitry.torokhov@gmail.com Signed-off-by: Dmitry Torokhov --- drivers/input/touchscreen/tps6507x-ts.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/input/touchscreen/tps6507x-ts.c b/drivers/input/touchscreen/tps6507x-ts.c index f48871767763..e84dc3ea1fcb 100644 --- a/drivers/input/touchscreen/tps6507x-ts.c +++ b/drivers/input/touchscreen/tps6507x-ts.c @@ -251,7 +251,6 @@ static int tps6507x_ts_probe(struct platform_device *pdev) input_dev->name = "TPS6507x Touchscreen"; input_dev->phys = tsc->phys; - input_dev->dev.parent = tsc->dev; input_dev->id.bustype = BUS_I2C; if (init_data) { input_dev->id.vendor = init_data->vendor;