github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-09-24 06:24:02 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

HID: asus: fix a off-by-one in mcu_parse_version_string() validation

Browse Source 
In mcu_parse_version_string() a size validation for response is stricter
that it needs to be: relax the check by one byte.

The device always answer with a greater byte count so this does
not introduce visible changes.

Fixes: ("hid-asus: check ROG Ally MCU version and warn")
Signed-off-by: Denis Benato <denis.benato@linux.dev>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
This commit is contained in:
Denis Benato 2026-06-19 00:11:01 +00:00 committed by Jiri Kosina
parent fb572e2f23
commit 2a767bd3e0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/hid/hid-asus.c
View File

@ -841,7 +841,7 @@ static int mcu_parse_version_string(const u8 *response, size_t response_size)
dots++;
}
if (dots != 2 || p >= end || (p + 3) >= end)
if (dots != 2 || end - p < 3)
return -EINVAL;
memcpy(buf, p, 3);