github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-11-07 06:17:02 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

soc: qcom: Remove redundant dev_err()

Browse Source 
Since commit 55b48e23f5 ("genirq/devres: Add error handling in
devm_request_*_irq()"),
devm_request_irq() and devm_request_threaded_irq() automatically log
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.

Signed-off-by: Pan Chuang <panchuang@vivo.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260723024248.17480-1-panchuang@vivo.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
This commit is contained in:
Pan Chuang 2026-07-23 10:42:47 +08:00 committed by Bjorn Andersson
parent f0c7f46249
commit 29b96e2769
3 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/soc/qcom/qcom_aoss.c
View File

@ -602,10 +602,8 @@ static int qmp_probe(struct platform_device *pdev)
irq = platform_get_irq(pdev, 0);
ret = devm_request_irq(&pdev->dev, irq, qmp_intr, 0,
"aoss-qmp", qmp);
if (ret < 0) {
dev_err(&pdev->dev, "failed to request interrupt\n");
if (ret < 0)
goto err_free_mbox;
}
ret = qmp_open(qmp);
if (ret < 0)

4
drivers/soc/qcom/smp2p.c
View File

@ -720,10 +720,8 @@ static int qcom_smp2p_probe(struct platform_device *pdev)
NULL, qcom_smp2p_intr,
IRQF_ONESHOT,
NULL, (void *)smp2p);
if (ret) {
dev_err(&pdev->dev, "failed to request interrupt\n");
if (ret)
goto unwind_interfaces;
}
/*
* Treat smp2p interrupt as wakeup source, but keep it disabled

4
drivers/soc/qcom/smsm.c
View File

@ -451,10 +451,8 @@ static int smsm_inbound_entry(struct qcom_smsm *smsm,
NULL, smsm_intr,
IRQF_ONESHOT,
"smsm", (void *)entry);
if (ret) {
dev_err(smsm->dev, "failed to request interrupt\n");
if (ret)
return ret;
}
entry->domain = irq_domain_create_linear(of_fwnode_handle(node), 32, &smsm_irq_ops, entry);
if (!entry->domain) {