From 28b94b06c64a1b423e64357f4c2cf3256f3a35f7 Mon Sep 17 00:00:00 2001 From: Pan Chuang Date: Thu, 9 Jul 2026 11:34:02 +0800 Subject: [PATCH] power: supply: max8903_charger: Remove redundant dev_err()/dev_err_probe() The devm_request_threaded_irq() and devm_request_irq() now automatically log detailed error messages on failure. This eliminates the need for driver-specific dev_err() and dev_err_probe() calls that previously printed generic messages. Signed-off-by: Pan Chuang Link: https://patch.msgid.link/20260709033428.362970-24-panchuang@vivo.com Signed-off-by: Sebastian Reichel --- drivers/power/supply/max8903_charger.c | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/power/supply/max8903_charger.c b/drivers/power/supply/max8903_charger.c index 45fbaad6c647..47334bfc8381 100644 --- a/drivers/power/supply/max8903_charger.c +++ b/drivers/power/supply/max8903_charger.c @@ -364,11 +364,8 @@ static int max8903_probe(struct platform_device *pdev) IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING | IRQF_ONESHOT, "MAX8903 DC IN", data); - if (ret) { - dev_err(dev, "Cannot request irq %d for DC (%d)\n", - gpiod_to_irq(data->dok), ret); + if (ret) return ret; - } } if (data->uok) { @@ -377,11 +374,8 @@ static int max8903_probe(struct platform_device *pdev) IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING | IRQF_ONESHOT, "MAX8903 USB IN", data); - if (ret) { - dev_err(dev, "Cannot request irq %d for USB (%d)\n", - gpiod_to_irq(data->uok), ret); + if (ret) return ret; - } } if (data->flt) { @@ -390,11 +384,8 @@ static int max8903_probe(struct platform_device *pdev) IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING | IRQF_ONESHOT, "MAX8903 Fault", data); - if (ret) { - dev_err(dev, "Cannot request irq %d for Fault (%d)\n", - gpiod_to_irq(data->flt), ret); + if (ret) return ret; - } } return 0;