github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-11-06 21:58:01 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

firewire: cdev: add annotations and comments about race condition of bus_reset_closure

Browse Source 
There is a race condition involving the bus_reset_closure member of the
fw_cdev_event_bus_reset structure, which was addressed by commit
93b37905f7 ("firewire: cdev: prevent race between first get_info ioctl
and bus reset event queuing").

Add code comments and annotations to document it.

Link: https://lore.kernel.org/r/20260920071501.77785-5-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
This commit is contained in:
Takashi Sakamoto 2026-09-20 16:15:00 +09:00
parent 1f6877ccef
commit 259ee8e255
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/firewire/core-cdev.c
View File

@ -398,7 +398,12 @@ static ssize_t fw_device_op_read(struct file *file, char __user *buffer,
static void fill_bus_reset_event(struct fw_cdev_event_bus_reset *event,
struct client *client)
__must_hold(&client->device->client_list_mutex)
{
lockdep_assert_held(&client->device->client_list_mutex);
// This member is related to the above mutex. In detail, see 93b37905f70 ("firewire: cdev:
// prevent race between first get_info ioctl and bus reset event queuing").
event->closure = client->bus_reset_closure;
event->type = FW_CDEV_EVENT_BUS_RESET;
@ -508,6 +513,9 @@ static int ioctl_get_info(struct client *client, union ioctl_arg *arg)
}
scoped_guard(mutex, &client->device->client_list_mutex) {
// Coordinate concurrent access to this member with bus reset event handling, see
// 93b37905f70 ("firewire: cdev: prevent race between first get_info ioctl and bus
// reset event queuing").
client->bus_reset_closure = a->bus_reset_closure;
if (a->bus_reset != 0) {