github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-12 16:18:45 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

kgdb: update outdated references to kgdb_wait()

Browse Source 
The function kgdb_wait() was folded into the static function
kgdb_cpu_enter() by commit 62fae31219 ("kgdb: eliminate
kgdb_wait(), all cpus enter the same way").  Update the four stale
references accordingly:

 - include/linux/kgdb.h and arch/x86/kernel/kgdb.c: the
   kgdb_roundup_cpus() kdoc describes what other CPUs are rounded up
   to call.  Because kgdb_cpu_enter() is static, the correct public
   entry point is kgdb_handle_exception(); also fix a pre-existing
   grammar error ("get them be" -> "get them into") and reflow the
   text.

 - kernel/debug/debug_core.c: replace with the generic description
   "the debug trap handler", since the actual entry path is
   architecture-specific.

 - kernel/debug/gdbstub.c: kgdb_cpu_enter() is correct here (it
   describes internal state, not a call target); add the missing
   parentheses.

Suggested-by: Daniel Thompson <daniel@riscstar.com>
Assisted-by: unnamed:deepseek-v3.2 coccinelle
Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>
This commit is contained in:
Kexin Sun 2026-03-24 11:23:44 +08:00 committed by Daniel Thompson
parent 028ef9c96e
commit 256e5254ef
4 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
arch/x86/kernel/kgdb.c
View File

@ -407,10 +407,11 @@ static void kgdb_disable_hw_debug(struct pt_regs *regs)
* kgdb_roundup_cpus - Get other CPUs into a holding pattern
*
* On SMP systems, we need to get the attention of the other CPUs
* and get them be in a known state. This should do what is needed
* to get the other CPUs to call kgdb_wait(). Note that on some arches,
* the NMI approach is not used for rounding up all the CPUs. For example,
* in case of MIPS, smp_call_function() is used to roundup CPUs.
* and get them into a known state. This should do what is needed
* to get the other CPUs to call kgdb_handle_exception(). Note that
* on some arches, the NMI approach is not used for rounding up all
* the CPUs. For example, in case of MIPS, smp_call_function() is
* used to roundup CPUs.
*
* On non-SMP systems, this is not called.
*/

7
include/linux/kgdb.h
View File

@ -202,9 +202,10 @@ extern void kgdb_call_nmi_hook(void *ignored);
*
* On SMP systems, we need to get the attention of the other CPUs
* and get them into a known state. This should do what is needed
* to get the other CPUs to call kgdb_wait(). Note that on some arches,
* the NMI approach is not used for rounding up all the CPUs. Normally
* those architectures can just not implement this and get the default.
* to get the other CPUs to call kgdb_handle_exception(). Note that
* on some arches, the NMI approach is not used for rounding up all
* the CPUs. Normally those architectures can just not implement
* this and get the default.
*
* On non-SMP systems, this is not called.
*/

2
kernel/debug/debug_core.c
View File

@ -704,7 +704,7 @@ static int kgdb_cpu_enter(struct kgdb_state *ks, struct pt_regs *regs,
if (ks->send_ready)
atomic_set(ks->send_ready, 1);
/* Signal the other CPUs to enter kgdb_wait() */
/* Signal the other CPUs to enter the debug trap handler */
else if ((!kgdb_single_step) && kgdb_do_roundup)
kgdb_roundup_cpus();
#endif

2
kernel/debug/gdbstub.c
View File

@ -517,7 +517,7 @@ static void gdb_get_regs_helper(struct kgdb_state *ks)
/*
* All threads that don't have debuggerinfo should be
* in schedule() sleeping, since all other CPUs
* are in kgdb_wait, and thus have debuggerinfo.
* are in kgdb_cpu_enter(), and thus have debuggerinfo.
*/
if (local_debuggerinfo) {
pt_regs_to_gdb_regs(gdb_regs, local_debuggerinfo);