github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-01 19:13:47 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

usbnet: ipheth: fix risk of NULL pointer deallocation

Browse Source 
The cleanup precedure in ipheth_probe will attempt to free a
NULL pointer in dev->ctrl_buf if the memory allocation for
this buffer is not successful. While kfree ignores NULL pointers,
and the existing code is safe, it is a better design to rearrange
the goto labels and avoid this.

Signed-off-by: Georgi Valkov <gvalkov@gmail.com>
Signed-off-by: Foster Snowhill <forst@pen.gy>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Georgi Valkov 2023-06-07 15:56:59 +02:00 committed by David S. Miller
parent fd5f4d7da2
commit 2203718c2f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/usb/ipheth.c
View File

@ -510,8 +510,8 @@ static int ipheth_probe(struct usb_interface *intf,
ipheth_free_urbs(dev);
err_alloc_urbs:
err_get_macaddr:
err_alloc_ctrl_buf:
kfree(dev->ctrl_buf);
err_alloc_ctrl_buf:
err_endpoints:
free_netdev(netdev);
return retval;