github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-04 04:23:35 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

selftests: net: forwarding: fix IPv6 address leak in cleanup

Browse Source 
Several forwarding tests (e.g., gre_multipath.sh) initialize both IPv4
and IPv6 addresses using simple_if_init, but only clean up IPv4
in simple_if_fini. This leaves stale IPv6 addresses on the interfaces,
which causes subsequent tests to fail when they encounter unexpected
address configuration.

The issue can be reproduced by running tests in sequence:
  # run_kselftest.sh -t net/forwarding:ipip_hier_gre.sh
  # run_kselftest.sh -t net/forwarding:min_max_mtu.sh
  TAP version 13
  1..1
  # timeout set to 0
  # selftests: net/forwarding: min_max_mtu.sh
  # TEST: ping                                                          [ OK ]
  # TEST: ping6                                                         [ OK ]
  # TEST: Test maximum MTU configuration                                [ OK ]
  # TEST: Test traffic, packet size is maximum MTU                      [FAIL]
  #       Ping6, packet size: 65487 succeeded, but should have failed
  # TEST: Test minimum MTU configuration                                [ OK ]
  # TEST: Test traffic, packet size is minimum MTU                      [ OK ]
  not ok 1 selftests: net/forwarding: min_max_mtu.sh # exit=1

Fix this by removing the unused IPv6 argument from simple_if_init in
tests that don't use IPv6 (gre_multipath.sh, ipip_lib.sh), and by
adding the missing IPv6 argument to simple_if_fini in tests that
use IPv6 (gre_multipath_nh.sh, gre_multipath_nh_res.sh).

Signed-off-by: Aleksei Oladko <aleksey.oladko@virtuozzo.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Link: https://patch.msgid.link/20260305211000.515301-1-aleksey.oladko@virtuozzo.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Aleksei Oladko 2026-03-05 21:10:00 +00:00 committed by Jakub Kicinski
parent ad4c955960
commit 21c0dc7cdd
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/testing/selftests/net/forwarding/gre_multipath.sh
View File

@ -65,7 +65,7 @@ source lib.sh
h1_create()
{
simple_if_init $h1 192.0.2.1/28 2001:db8:1::1/64
simple_if_init $h1 192.0.2.1/28
ip route add vrf v$h1 192.0.2.16/28 via 192.0.2.2
}

2
tools/testing/selftests/net/forwarding/gre_multipath_nh.sh
View File

@ -80,7 +80,7 @@ h1_destroy()
{
ip route del vrf v$h1 2001:db8:2::/64 via 2001:db8:1::2
ip route del vrf v$h1 192.0.2.16/28 via 192.0.2.2
simple_if_fini $h1 192.0.2.1/28
simple_if_fini $h1 192.0.2.1/28 2001:db8:1::1/64
}
sw1_create()

2
tools/testing/selftests/net/forwarding/gre_multipath_nh_res.sh
View File

@ -80,7 +80,7 @@ h1_destroy()
{
ip route del vrf v$h1 2001:db8:2::/64 via 2001:db8:1::2
ip route del vrf v$h1 192.0.2.16/28 via 192.0.2.2
simple_if_fini $h1 192.0.2.1/28
simple_if_fini $h1 192.0.2.1/28 2001:db8:1::1/64
}
sw1_create()

2
tools/testing/selftests/net/forwarding/ipip_lib.sh
View File

@ -144,7 +144,7 @@
h1_create()
{
simple_if_init $h1 192.0.2.1/28 2001:db8:1::1/64
simple_if_init $h1 192.0.2.1/28
ip route add vrf v$h1 192.0.2.16/28 via 192.0.2.2
}