From 2123813511d495b99b605abe4db167793698e0c5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Th=C3=A9o=20Lebrun?= Date: Wed, 1 Jul 2026 18:56:59 +0200 Subject: [PATCH] gpio: nomadik: add missing dev_err() call on chip populate failure MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit All error paths of nmk_gpio_populate_chip() lead to logging errors but this one (ignoring the alloc or ioremap failures that must not log). Add the single missing dev_err() call. Signed-off-by: Théo Lebrun Reviewed-by: Linus Walleij Link: https://patch.msgid.link/20260701-gpio-nomadik-silent-v1-2-644d10316cef@bootlin.com Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-nomadik.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpio/gpio-nomadik.c b/drivers/gpio/gpio-nomadik.c index f25f251f4757..4a7db282bad8 100644 --- a/drivers/gpio/gpio-nomadik.c +++ b/drivers/gpio/gpio-nomadik.c @@ -578,6 +578,7 @@ struct nmk_gpio_chip *nmk_gpio_populate_chip(struct fwnode_handle *fwnode, clk = clk_get_optional(gpio_dev, NULL); if (IS_ERR(clk)) { ret = PTR_ERR(clk); + dev_err(dev, "failed getting clock: %d\n", ret); goto err_put_pdev; } clk_prepare(clk);