mirror of
https://github.com/torvalds/linux.git
synced 2026-05-24 15:12:13 +02:00
i2c: davinci: Use struct name not type with devm_kzalloc()
This reduces chance of error if the type of "dev" changes. While here remove extra error print out, this is not usually done for memory allocation failures. Signed-off-by: Andrew Davis <afd@ti.com> Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Signed-off-by: Wolfram Sang <wsa@kernel.org>
This commit is contained in:
parent
c3cc5c59cb
commit
1ebafd5f5c
|
|
@ -767,12 +767,9 @@ static int davinci_i2c_probe(struct platform_device *pdev)
|
|||
if (irq < 0)
|
||||
return dev_err_probe(&pdev->dev, irq, "can't get irq resource\n");
|
||||
|
||||
dev = devm_kzalloc(&pdev->dev, sizeof(struct davinci_i2c_dev),
|
||||
GFP_KERNEL);
|
||||
if (!dev) {
|
||||
dev_err(&pdev->dev, "Memory allocation failed\n");
|
||||
dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL);
|
||||
if (!dev)
|
||||
return -ENOMEM;
|
||||
}
|
||||
|
||||
init_completion(&dev->cmd_complete);
|
||||
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user