From 61fb67dae505d71da5f17752b46aaacc3939c10f Mon Sep 17 00:00:00 2001 From: Corentin Labbe Date: Sat, 15 Jan 2022 10:04:43 +0000 Subject: [PATCH 1/3] ARM: dts: gemini: ns2502: permit to use gigabit I believed that gigabit was not working due to some unknown missing GPIO. In fact, gigabit worked when REALTEK_PHY was compiled out. So the problem was due to PHY delay and we need to use rgmii-id. Signed-off-by: Corentin Labbe Signed-off-by: Linus Walleij --- arch/arm/boot/dts/gemini-ns2502.dts | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/arch/arm/boot/dts/gemini-ns2502.dts b/arch/arm/boot/dts/gemini-ns2502.dts index 704abd212df5..508bb5846e29 100644 --- a/arch/arm/boot/dts/gemini-ns2502.dts +++ b/arch/arm/boot/dts/gemini-ns2502.dts @@ -39,10 +39,6 @@ mdio0: mdio { phy0: ethernet-phy@1 { reg = <1>; device_type = "ethernet-phy"; - /* We lack the knowledge of necessary GPIO to achieve - * Gigabit - */ - max-speed = <100>; }; }; }; @@ -50,7 +46,7 @@ phy0: ethernet-phy@1 { ðernet { status = "okay"; ethernet-port@0 { - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; phy-handle = <&phy0>; }; }; From 95bef83078a4de295c1ae4690937623f2237b8ac Mon Sep 17 00:00:00 2001 From: Corentin Labbe Date: Sat, 15 Jan 2022 10:04:44 +0000 Subject: [PATCH 2/3] ARM: dts: gemini: ssi1328: permit to use gigabit I believed that gigabit was not working due to unknown missing GPIO. But the problem was due to Marvell PHY incorrectly setting delay. Now it is fixed, gigabit works. Signed-off-by: Corentin Labbe Signed-off-by: Linus Walleij --- arch/arm/boot/dts/gemini-ssi1328.dts | 4 ---- 1 file changed, 4 deletions(-) diff --git a/arch/arm/boot/dts/gemini-ssi1328.dts b/arch/arm/boot/dts/gemini-ssi1328.dts index 2b3e7db84fed..42e85f07cf76 100644 --- a/arch/arm/boot/dts/gemini-ssi1328.dts +++ b/arch/arm/boot/dts/gemini-ssi1328.dts @@ -40,10 +40,6 @@ mdio0: mdio { phy0: ethernet-phy@1 { reg = <1>; device_type = "ethernet-phy"; - /* We lack the knowledge of necessary GPIO to achieve - * Gigabit - */ - max-speed = <100>; }; /* WAN ICPlus IP101A */ phy1: ethernet-phy@2 { From f485f6d852696d4cd9a2cc1c8e3dd8dba75a3e17 Mon Sep 17 00:00:00 2001 From: Linus Walleij Date: Wed, 13 Apr 2022 00:03:58 +0200 Subject: [PATCH 3/3] ARM: dts: Let Gemini NS2502 parse redboot partitions The NS2502 uses hardcoded partitions but parsing the RedBoot FIS should work fine, given that this flash seems to be using 0x200000 erase blocks. Cc: Corentin Labbe Link: https://lore.kernel.org/r/20220412220358.3674598-1-linus.walleij@linaro.org Signed-off-by: Linus Walleij --- arch/arm/boot/dts/gemini-ns2502.dts | 27 +++------------------------ 1 file changed, 3 insertions(+), 24 deletions(-) diff --git a/arch/arm/boot/dts/gemini-ns2502.dts b/arch/arm/boot/dts/gemini-ns2502.dts index 508bb5846e29..e6eeb35e8819 100644 --- a/arch/arm/boot/dts/gemini-ns2502.dts +++ b/arch/arm/boot/dts/gemini-ns2502.dts @@ -61,30 +61,9 @@ &flash { pinctrl-1 = <&pflash_disabled_pins>; partitions { - compatible = "fixed-partitions"; - #address-cells = <1>; - #size-cells = <1>; - - partition@0 { - label = "RedBoot"; - reg = <0x00000000 0x00020000>; - }; - partition@20000 { - label = "kernel"; - reg = <0x00020000 0x00700000>; - }; - partition@720000 { - label = "VCTL"; - reg = <0x00720000 0x00020000>; - }; - partition@740000 { - label = "CurConf"; - reg = <0x00740000 0x000a0000>; - }; - partition@7e0000 { - label = "FIS"; - reg = <0x007e0000 0x00010000>; - }; + compatible = "redboot-fis"; + /* Eraseblock at 0x7e0000 */ + fis-index-block = <0x3f>; }; };