github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-09-24 06:24:02 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

media: v4l2-core: v4l2-dev: add comments on device_register fail.

Browse Source 
If device_register fails, then we are supposed to call put_device.
Explain why we do not do that.

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
This commit is contained in:
Hans Verkuil 2026-07-17 15:42:46 +02:00
parent e7600f5cee
commit 1d21691540
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/media/v4l2-core/v4l2-dev.c
View File

@ -1075,6 +1075,20 @@ int __video_register_device(struct video_device *vdev,
mutex_lock(&videodev_lock);
ret = device_register(&vdev->dev);
if (ret < 0) {
/*
* We should do a put_device() here, but the problem is that
* the V4L2 API expects drivers to call video_device_release()
* on error, and so both put_device() and video_device_release
* would kfree vdev.
*
* The proper solution would be to split this function into
* two parts: initialization and registration, and then rework
* all drivers.
*
* Until then just skip the put_device and free everything.
* This will result in a small memory leak, which is better
* than a double-free.
*/
mutex_unlock(&videodev_lock);
pr_err("%s: device_register failed\n", __func__);
goto cleanup;