From 1d0a73dd0c4f5a904ece163fdd24c7e03de0fb1b Mon Sep 17 00:00:00 2001 From: Tao Cui Date: Fri, 14 Aug 2026 07:01:23 +0800 Subject: [PATCH] sched_ext: fix stale references in doc comments - inlines.h: scx_bpf_dispatch() doesn't exist; the comment means scx_bpf_sub_dispatch() - internal.h: name %SCX_DEQ_SCHED_CHANGE instead of the never-defined %SCX_DEQ_SAVE - internal.h: @name shows up in the ops file in the scheduler's sysfs directory, not a "kernel.sched_ext_ops" sysctl Signed-off-by: Tao Cui Signed-off-by: Tejun Heo --- kernel/sched/ext/inlines.h | 2 +- kernel/sched/ext/internal.h | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/kernel/sched/ext/inlines.h b/kernel/sched/ext/inlines.h index 72d5ccd819d1..8f3be59863e5 100644 --- a/kernel/sched/ext/inlines.h +++ b/kernel/sched/ext/inlines.h @@ -22,7 +22,7 @@ enum scx_dsp_verdict { }; /* - * One user of this function is scx_bpf_dispatch() which can be called + * One user of this function is scx_bpf_sub_dispatch() which can be called * recursively as sub-sched dispatches nest. Always inline to reduce stack usage * from the call frame. */ diff --git a/kernel/sched/ext/internal.h b/kernel/sched/ext/internal.h index b699e7c1103f..c91296c53225 100644 --- a/kernel/sched/ext/internal.h +++ b/kernel/sched/ext/internal.h @@ -485,7 +485,7 @@ struct sched_ext_ops { * - sleeping (%SCX_DEQ_SLEEP) * - being moved to another CPU * - being temporarily taken off the queue for an attribute change - * (%SCX_DEQ_SAVE) + * (%SCX_DEQ_SCHED_CHANGE) * * This and ->dequeue() are related but not coupled. This operation * notifies @p's state transition and may not be preceded by ->dequeue() @@ -966,8 +966,9 @@ struct sched_ext_ops { * @name: BPF scheduler's name * * Must be a non-zero valid BPF object name including only isalnum(), - * '_' and '.' chars. Shows up in kernel.sched_ext_ops sysctl while the - * BPF scheduler is enabled. + * '_' and '.' chars. Exposed via the ops file in the scheduler's sysfs + * directory, /sys/kernel/sched_ext/root/ops for the root scheduler, + * while the BPF scheduler is enabled. */ char name[SCX_OPS_NAME_LEN];