github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-09-24 06:24:02 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

drm/msm/dp: move mode setup into msm_dp_panel_init_panel_info()

Browse Source 
The display layer directly assigns msm_dp_panel mode fields (bpp,
sync polarity, yuv420 flag) instead of letting the panel manage its
own state. Pass adjusted_mode and bpp as parameters to
msm_dp_panel_init_panel_info() and move the assignments inside it.

Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patchwork: https://patchwork.freedesktop.org/patch/742731/
Link: https://lore.kernel.org/r/20260728-dp_mstclean-v9-3-f7779fce10f4@oss.qualcomm.com
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
This commit is contained in:
Yongxing Mou 2026-07-28 18:21:32 +08:00 committed by Dmitry Baryshkov
parent cd07d63588
commit 1c96c88ec1
3 changed files with 19 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/gpu/drm/msm/dp/dp_display.c
View File

@ -604,21 +604,12 @@ static int msm_dp_display_set_mode(struct msm_dp *msm_dp_display,
dp = container_of(msm_dp_display, struct msm_dp_display_private, msm_dp_display);
drm_mode_copy(&msm_dp_panel->msm_dp_mode.drm_mode, adjusted_mode);
if (msm_dp_display_check_video_test(msm_dp_display))
bpp = msm_dp_display_get_test_bpp(msm_dp_display);
else
bpp = msm_dp_panel->connector->display_info.bpc * 3;
msm_dp_panel->msm_dp_mode.bpp = bpp ? bpp : 24; /* Default bpp */
msm_dp_panel->msm_dp_mode.v_active_low =
!!(adjusted_mode->flags & DRM_MODE_FLAG_NVSYNC);
msm_dp_panel->msm_dp_mode.h_active_low =
!!(adjusted_mode->flags & DRM_MODE_FLAG_NHSYNC);
msm_dp_panel->msm_dp_mode.out_fmt_is_yuv_420 =
drm_mode_is_420_only(&msm_dp_panel->connector->display_info, adjusted_mode) &&
msm_dp_panel->vsc_sdp_supported;
msm_dp_panel_init_panel_info(msm_dp_panel);
msm_dp_panel_init_panel_info(msm_dp_panel, adjusted_mode, bpp ? bpp : 24);
/* populate wide_bus_support to different layers */
dp->ctrl->wide_bus_en =

18
drivers/gpu/drm/msm/dp/dp_panel.c
View File

@ -647,15 +647,27 @@ int msm_dp_panel_timing_cfg(struct msm_dp_panel *msm_dp_panel, bool wide_bus_en)
return 0;
}
int msm_dp_panel_init_panel_info(struct msm_dp_panel *msm_dp_panel)
int msm_dp_panel_init_panel_info(struct msm_dp_panel *msm_dp_panel,
const struct drm_display_mode *adjusted_mode,
u32 bpp)
{
struct drm_display_mode *drm_mode;
struct msm_dp_panel_private *panel;
drm_mode = &msm_dp_panel->msm_dp_mode.drm_mode;
panel = container_of(msm_dp_panel, struct msm_dp_panel_private, msm_dp_panel);
drm_mode_copy(&msm_dp_panel->msm_dp_mode.drm_mode, adjusted_mode);
msm_dp_panel->msm_dp_mode.bpp = bpp;
msm_dp_panel->msm_dp_mode.v_active_low =
!!(adjusted_mode->flags & DRM_MODE_FLAG_NVSYNC);
msm_dp_panel->msm_dp_mode.h_active_low =
!!(adjusted_mode->flags & DRM_MODE_FLAG_NHSYNC);
msm_dp_panel->msm_dp_mode.out_fmt_is_yuv_420 =
drm_mode_is_420_only(&msm_dp_panel->connector->display_info, adjusted_mode) &&
msm_dp_panel->vsc_sdp_supported;
drm_mode = &msm_dp_panel->msm_dp_mode.drm_mode;
/*
* print resolution info as this is a result
* of user initiated action of cable connection

4
drivers/gpu/drm/msm/dp/dp_panel.h
View File

@ -43,7 +43,9 @@ struct msm_dp_panel {
u32 max_bw_code;
};
int msm_dp_panel_init_panel_info(struct msm_dp_panel *msm_dp_panel);
int msm_dp_panel_init_panel_info(struct msm_dp_panel *msm_dp_panel,
const struct drm_display_mode *adjusted_mode,
u32 bpp);
int msm_dp_panel_deinit(struct msm_dp_panel *msm_dp_panel);
int msm_dp_panel_timing_cfg(struct msm_dp_panel *msm_dp_panel, bool wide_bus_en);
int msm_dp_panel_read_link_caps(struct msm_dp_panel *msm_dp_panel,