iomap: only call into ->submit_read when there is a read_ctx

Move the NULL check into the callers to simplify the callees.

Fuse was missing this before, but has a constant read_ctx that is
never NULL or changed, so no change here either.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Link: https://patch.msgid.link/20260223132021.292832-11-hch@lst.de
Tested-by: Anuj Gupta <anuj20.g@samsung.com>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
Signed-off-by: Christian Brauner <brauner@kernel.org>
This commit is contained in:
Christoph Hellwig 2026-02-23 05:20:10 -08:00 committed by Christian Brauner
parent 4d25c7d688
commit 19fb5f9780
No known key found for this signature in database
GPG Key ID: 91C61BC06578DCA2
3 changed files with 4 additions and 8 deletions

View File

@ -21,10 +21,7 @@ static void iomap_read_end_io(struct bio *bio)
static void iomap_bio_submit_read(const struct iomap_iter *iter,
struct iomap_read_folio_ctx *ctx)
{
struct bio *bio = ctx->read_ctx;
if (bio)
submit_bio(bio);
submit_bio(ctx->read_ctx);
}
static void iomap_read_alloc_bio(const struct iomap_iter *iter,

View File

@ -596,7 +596,7 @@ void iomap_read_folio(const struct iomap_ops *ops,
iter.status = iomap_read_folio_iter(&iter, ctx,
&bytes_submitted);
if (ctx->ops->submit_read)
if (ctx->read_ctx && ctx->ops->submit_read)
ctx->ops->submit_read(&iter, ctx);
if (ctx->cur_folio)
@ -663,7 +663,7 @@ void iomap_readahead(const struct iomap_ops *ops,
iter.status = iomap_readahead_iter(&iter, ctx,
&cur_bytes_submitted);
if (ctx->ops->submit_read)
if (ctx->read_ctx && ctx->ops->submit_read)
ctx->ops->submit_read(&iter, ctx);
if (ctx->cur_folio)

View File

@ -656,8 +656,7 @@ static void ntfs_iomap_bio_submit_read(const struct iomap_iter *iter,
{
struct bio *bio = ctx->read_ctx;
if (bio)
submit_bio(bio);
submit_bio(bio);
}
static const struct iomap_read_ops ntfs_iomap_bio_read_ops = {