From 1867db62c1483f3d67820511e7beef27a506728a Mon Sep 17 00:00:00 2001 From: Pan Chuang Date: Wed, 22 Jul 2026 15:57:46 +0800 Subject: [PATCH] fbdev: s3c-fb: Remove redundant dev_err() Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() call. Signed-off-by: Pan Chuang Signed-off-by: Helge Deller --- drivers/video/fbdev/s3c-fb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c index 2f4d707e2e09..82a3bc9de433 100644 --- a/drivers/video/fbdev/s3c-fb.c +++ b/drivers/video/fbdev/s3c-fb.c @@ -1421,10 +1421,8 @@ static int s3c_fb_probe(struct platform_device *pdev) ret = devm_request_irq(dev, sfb->irq_no, s3c_fb_irq, 0, "s3c_fb", sfb); - if (ret) { - dev_err(dev, "irq request failed\n"); + if (ret) goto err_lcd_clk; - } dev_dbg(dev, "got resources (regs %p), probing windows\n", sfb->regs);