github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-03 20:14:06 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

firewire: core: remove useless generation check

Browse Source 
Two functions, fw_core_handle_bus_reset() and bm_work(), are serialized
by a commit 3d91fd440cc7 ("firewire: core: disable bus management work
temporarily during updating topology"). Therefore the generation member
of fw_card is immutable in bm_work().

This commit removes useless generation check in bm_work().

Link: https://lore.kernel.org/r/20250918235448.129705-2-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
This commit is contained in:
Takashi Sakamoto 2025-09-19 08:54:43 +09:00
parent e6d2338b6f
commit 182edc05b0
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/firewire/core-card.c
View File

@ -362,14 +362,12 @@ static void bm_work(struct work_struct *work)
if (rcode == RCODE_COMPLETE) {
int bm_id = be32_to_cpu(data[0]);
if (generation == card->generation) {
// Used by cdev layer for "struct fw_cdev_event_bus_reset".
scoped_guard(spinlock, &card->lock) {
if (bm_id != BUS_MANAGER_ID_NOT_REGISTERED)
card->bm_node_id = 0xffc0 & bm_id;
else
card->bm_node_id = local_id;
}
// Used by cdev layer for "struct fw_cdev_event_bus_reset".
scoped_guard(spinlock, &card->lock) {
if (bm_id != BUS_MANAGER_ID_NOT_REGISTERED)
card->bm_node_id = 0xffc0 & bm_id;
else
card->bm_node_id = local_id;
}
if (bm_id != BUS_MANAGER_ID_NOT_REGISTERED) {