github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-04 12:35:52 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

Input: zforce_ts - stop treating VDD regulator as optional

Browse Source 
This regulator is not optional from the controller point of view,
so stop treating it as such. For hard-wired designs that omit the
regulator from their device trees regulator subsystem will create
a dummy instance.

This may introduce unnecessary delay of 100us in case of dummy
regulator, but if it is important the driver should be marked as
using asynchronous probing to avoid even longer delays waiting for
the command completions.

Also use usleep_range() instead of udelay() to avoid spinning.

Tested-by: Andreas Kemnade <andreas@kemnade.info> # Tolino Shine2HD
Link: https://lore.kernel.org/r/20240824055047.1706392-15-dmitry.torokhov@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
This commit is contained in:
Dmitry Torokhov 2024-08-23 22:50:38 -07:00
parent b5ed81cc7b
commit 16ff0224d8
1 changed files with 13 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
drivers/input/touchscreen/zforce_ts.c
View File

@ -742,23 +742,21 @@ static int zforce_probe(struct i2c_client *client)
"failed to request reset GPIO\n");
}
ts->reg_vdd = devm_regulator_get_optional(&client->dev, "vdd");
ts->reg_vdd = devm_regulator_get(&client->dev, "vdd");
error = PTR_ERR_OR_ZERO(ts->gpio_rst);
if (error) {
if (error != -ENOENT)
return dev_err_probe(&client->dev, error,
"failed to request vdd supply\n");
} else {
error = regulator_enable(ts->reg_vdd);
if (error)
return error;
if (error)
return dev_err_probe(&client->dev, error,
"failed to request vdd supply\n");
/*
* according to datasheet add 100us grace time after regular
* regulator enable delay.
*/
udelay(100);
}
error = regulator_enable(ts->reg_vdd);
if (error)
return error;
/*
* According to datasheet add 100us grace time after regular
* regulator enable delay.
*/
usleep_range(100, 200);
error = devm_add_action_or_reset(&client->dev, zforce_reset, ts);
if (error)