From 16710bcb96405b71ff8b9ebcc0923707d4c61615 Mon Sep 17 00:00:00 2001 From: Maxime Ripard Date: Fri, 19 Jun 2026 14:24:10 +0200 Subject: [PATCH] drm/atomic-state-helper: Drop memset from __drm_atomic_helper_bridge_state_init() __drm_atomic_helper_bridge_state_init() is always called on a freshly kzalloc-ed state, so the memset is redundant. Drop it and document the expectation that the state is already zeroed. Reviewed-by: Thomas Zimmermann Reviewed-by: Luca Ceresoli Reviewed-by: Laurent Pinchart Tested-by: Luca Ceresoli # imx8mp + sn65dsi84 + bridge hotplug Link: https://patch.msgid.link/20260619-drm-no-more-bridge-reset-v3-5-ff399263111b@kernel.org Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_atomic_state_helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_atomic_state_helper.c b/drivers/gpu/drm/drm_atomic_state_helper.c index 8f04eae7a754..f0688f2d83fe 100644 --- a/drivers/gpu/drm/drm_atomic_state_helper.c +++ b/drivers/gpu/drm/drm_atomic_state_helper.c @@ -891,6 +891,8 @@ EXPORT_SYMBOL(drm_atomic_helper_bridge_destroy_state); * @state: bridge state to initialize * @bridge: the bridge this state refers to * + * @state is assumed to be zeroed. + * * Initializes the bridge state to default values. This is meant to be called * by the bridge &drm_bridge_funcs.atomic_reset hook for bridges that subclass * the bridge state. @@ -898,7 +900,6 @@ EXPORT_SYMBOL(drm_atomic_helper_bridge_destroy_state); void __drm_atomic_helper_bridge_state_init(struct drm_bridge_state *state, struct drm_bridge *bridge) { - memset(state, 0, sizeof(*state)); __drm_atomic_helper_private_obj_create_state(&bridge->base, &state->base); state->bridge = bridge; }