github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-26 16:12:59 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

platform/x86: intel/rst: Convert ACPI driver to a platform one

Browse Source 
In all cases in which a struct acpi_driver is used for binding a driver
to an ACPI device object, a corresponding platform device is created by
the ACPI core and that device is regarded as a proper representation of
underlying hardware.  Accordingly, a struct platform_driver should be
used by driver code to bind to that device.  There are multiple reasons
why drivers should not bind directly to ACPI device objects [1].

Overall, it is better to bind drivers to platform devices than to their
ACPI companions, so convert the Intel Rapid Start Technology (rst) ACPI
driver to a platform one.

While this is not expected to alter functionality, it changes sysfs
layout and so it will be visible to user space.

Link: https://lore.kernel.org/all/2396510.ElGaqSPkdT@rafael.j.wysocki/ [1]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/3599223.QJadu78ljV@rafael.j.wysocki
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
This commit is contained in:
Rafael J. Wysocki 2026-02-28 16:27:33 +01:00 committed by Ilpo Järvinen
parent 079b59fd2d
commit 163a68a31f
No known key found for this signature in database
GPG Key ID: 59AC4F6153E5CE31
1 changed files with 13 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
drivers/platform/x86/intel/rst.c
View File

@ -5,6 +5,7 @@
#include <linux/acpi.h> #include <linux/acpi.h>
#include <linux/module.h> #include <linux/module.h>
#include <linux/platform_device.h>
#include <linux/slab.h> #include <linux/slab.h>
MODULE_DESCRIPTION("Intel Rapid Start Technology Driver"); MODULE_DESCRIPTION("Intel Rapid Start Technology Driver");
@ -99,8 +100,9 @@ static struct device_attribute irst_timeout_attr = {
.store = irst_store_wakeup_time .store = irst_store_wakeup_time
}; };
static int irst_add(struct acpi_device *acpi) static int irst_probe(struct platform_device *pdev)
{ {
struct acpi_device *acpi = ACPI_COMPANION(&pdev->dev);
int error; int error;
error = device_create_file(&acpi->dev, &irst_timeout_attr); error = device_create_file(&acpi->dev, &irst_timeout_attr);
@ -114,8 +116,10 @@ static int irst_add(struct acpi_device *acpi)
return error; return error;
} }
static void irst_remove(struct acpi_device *acpi) static void irst_remove(struct platform_device *pdev)
{ {
struct acpi_device *acpi = ACPI_COMPANION(&pdev->dev);
device_remove_file(&acpi->dev, &irst_wakeup_attr); device_remove_file(&acpi->dev, &irst_wakeup_attr);
device_remove_file(&acpi->dev, &irst_timeout_attr); device_remove_file(&acpi->dev, &irst_timeout_attr);
} }
@ -125,16 +129,15 @@ static const struct acpi_device_id irst_ids[] = {
{"", 0} {"", 0}
}; };
static struct acpi_driver irst_driver = { static struct platform_driver irst_driver = {
.name = "intel_rapid_start", .probe = irst_probe,
.class = "intel_rapid_start", .remove = irst_remove,
.ids = irst_ids, .driver = {
.ops = { .name = "intel_rapid_start",
.add = irst_add, .acpi_match_table = irst_ids,
.remove = irst_remove,
}, },
}; };
module_acpi_driver(irst_driver); module_platform_driver(irst_driver);
MODULE_DEVICE_TABLE(acpi, irst_ids); MODULE_DEVICE_TABLE(acpi, irst_ids);