github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-11-07 06:17:02 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

handshake: Fix sign of key_serial_t fields

Browse Source 
key_serial_t fields are signed integers. Use nla_get/put_s32 for
those to avoid implicit signed conversion in the netlink protocol.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/169530167716.8905.645746457741372879.stgit@oracle-102.nfsv4bat.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Chuck Lever 2023-09-21 09:08:07 -04:00 committed by Jakub Kicinski
parent a6b07a51b1
commit 160f404495
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Documentation/netlink/specs/handshake.yaml
View File

@ -34,10 +34,10 @@ attribute-sets:
attributes: attributes:
- -
name: cert name: cert
type: u32 type: s32
- -
name: privkey name: privkey
type: u32 type: s32
- -
name: accept name: accept
attributes: attributes:

4
net/handshake/tlshd.c
View File

@ -173,9 +173,9 @@ static int tls_handshake_put_certificate(struct sk_buff *msg,
if (!entry_attr) if (!entry_attr)
return -EMSGSIZE; return -EMSGSIZE;
if (nla_put_u32(msg, HANDSHAKE_A_X509_CERT, if (nla_put_s32(msg, HANDSHAKE_A_X509_CERT,
treq->th_certificate) || treq->th_certificate) ||
nla_put_u32(msg, HANDSHAKE_A_X509_PRIVKEY, nla_put_s32(msg, HANDSHAKE_A_X509_PRIVKEY,
treq->th_privkey)) { treq->th_privkey)) {
nla_nest_cancel(msg, entry_attr); nla_nest_cancel(msg, entry_attr);
return -EMSGSIZE; return -EMSGSIZE;

4
tools/net/ynl/generated/handshake-user.h
View File

@ -28,8 +28,8 @@ struct handshake_x509 {
__u32 privkey:1; __u32 privkey:1;
} _present; } _present;
__u32 cert; __s32 cert;
__u32 privkey; __s32 privkey;
}; };
/* ============== HANDSHAKE_CMD_ACCEPT ============== */ /* ============== HANDSHAKE_CMD_ACCEPT ============== */