github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-28 17:13:52 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

iio: dac: ad5446: Don't ignore missing regulator

Browse Source 
If the chip does not have an internal reference, do not ignore a missing
regulator as we won't be able to actually provide a proper scale for the
DAC. Since it's now seen as an error, flip the if() logic so errors are
treated first (which is the typical pattern).

Signed-off-by: Nuno Sá <nuno.sa@analog.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This commit is contained in:
Nuno Sá 2025-11-04 15:35:09 +00:00 committed by Jonathan Cameron
parent 63232c9b54
commit 14b72d8ace
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/iio/dac/ad5446.c
View File

@ -255,10 +255,11 @@ static int ad5446_probe(struct device *dev, const char *name,
if (ret < 0 && ret != -ENODEV)
return ret;
if (ret == -ENODEV) {
if (chip_info->int_vref_mv)
st->vref_mv = chip_info->int_vref_mv;
else
dev_warn(dev, "reference voltage unspecified\n");
if (!chip_info->int_vref_mv)
return dev_err_probe(dev, ret,
"reference voltage unspecified\n");
st->vref_mv = chip_info->int_vref_mv;
} else {
st->vref_mv = ret / 1000;
}